Cleanup of trie.Trie type (decoupling from database and resolver) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00ris
reviewed
Jun 8, 2019
| @@ -836,23 +764,25 @@ func testStartup() { | |||
| func testResolve() { | |||
| startTime := time.Now() | |||
| //ethDb, err := ethdb.NewBoltDatabase("/home/akhounov/.ethereum/geth/chaindata") | |||
| //ethDb, err := ethdb.NewBoltDatabase("/Users/alexeyakhunov/Library/Ethereum/geth/chaindata") | |||
| ethDb, err := ethdb.NewBoltDatabase("statedb") | |||
| ethDb, err := ethdb.NewBoltDatabase("/Users/alexeyakhunov/Library/Ethereum/geth/chaindata") | |||
There was a problem hiding this comment.
I think we need to change the path.
There was a problem hiding this comment.
Yes, it is my "hacking" toolkit, which I think will need to be transformed into a proper debugging toolkit
There was a problem hiding this comment.
Actually, I will also add more tests for these things rather
| @@ -144,7 +144,7 @@ func TestIntermediateLeaks(t *testing.T) { | |||
| // TestCopy tests that copying a statedb object indeed makes the original and | |||
| // the copy independent of each other. This test is a regression test against | |||
| // https://github.com/ethereum/go-ethereum/pull/15549. | |||
| func TestCopy(t *testing.T) { | |||
| func testCopy(t *testing.T) { | |||
There was a problem hiding this comment.
Yes, for now because it causes that concurrent map writing bug. I will remove the ability to copy TrieDbState altogether
b00ris
reviewed
Jun 8, 2019
| // Updates a node to the current timestamp | ||
| // contract is effectively address of the smart contract | ||
| // hex is the prefix of the key | ||
| func (tp *TriePruning) touch(contract []byte, hex []byte, parent, n node) { |
There was a problem hiding this comment.
I should not have included this, it is to be extended
racytech
pushed a commit
to racytech/erigon
that referenced
this pull request
Apr 1, 2023
… latest (erigontech#36) Co-authored-by: Roberto Bayardo <>
pcw109550
pushed a commit
to testinprod-io/erigon
that referenced
this pull request
May 19, 2023
Change repository name & docker image tag
revitteth
referenced
this pull request
in 0xPolygonHermez/cdk-erigon
Dec 12, 2023
revitteth
referenced
this pull request
in 0xPolygonHermez/cdk-erigon
Dec 12, 2023
* feat(zk): l1 verifications download and store * feat(zk): chainconfig util and stateroot storage on vbatch
revitteth
referenced
this pull request
in 0xPolygonHermez/cdk-erigon
Dec 14, 2023
revitteth
referenced
this pull request
in 0xPolygonHermez/cdk-erigon
Dec 14, 2023
* feat(zk): l1 verifications download and store * feat(zk): chainconfig util and stateroot storage on vbatch
cffls
pushed a commit
to cffls/erigon
that referenced
this pull request
Jan 12, 2024
* calculate effective gas percentage after mordor * removed commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.