[SharovBot] fix: add 0x prefix to structLog storage keys and values#20732
Closed
erigon-copilot[bot] wants to merge 1 commit into
Closed
[SharovBot] fix: add 0x prefix to structLog storage keys and values#20732erigon-copilot[bot] wants to merge 1 commit into
erigon-copilot[bot] wants to merge 1 commit into
Conversation
debug_traceBlockByNumber and debug_traceCall were returning storage keys/values in structLogs without the 0x prefix, e.g.: "2fa8c5322c...": "0000..." go-ethereum returns them with the 0x prefix: "0x2fa8c5322c...": "0x0000..." This caused two RPC integration test failures on release/3.4 (debug_traceBlockByNumber/test_42 and debug_traceCall/test_43) across all commits. Fix the three code paths that format storage in structLogs: - execution/tracing/tracers/logger/json_stream.go (streaming path used by debug_traceCall and debug_traceBlockByNumber) - execution/tracing/tracers/logger/logger.go (StructLogger format path) - rpc/ethapi/api.go (ethapi format path) Co-authored-by: Giulio Rebuffo <giulio.rebuffo@gmail.com>
erigon-copilot
Bot
requested review from
canepat,
lupin012,
mh0lt and
yperbasis
as code owners
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SharovBot]
Problem
debug_traceBlockByNumberanddebug_traceCallwere returning storage keys/values instructLogswithout the0xprefix:go-ethereum returns them with the
0xprefix:This caused two RPC integration test failures on release/3.4 across all 10 recent commits:
debug_traceBlockByNumber/test_42debug_traceCall/test_43Fix
Add
0xprefix to storage keys and values in the three code paths that format structLog storage:execution/tracing/tracers/logger/json_stream.go— streaming path (used bydebug_traceCallanddebug_traceBlockByNumber)execution/tracing/tracers/logger/logger.go— StructLogger format pathrpc/ethapi/api.go— ethapi format pathTesting
Verified by:
go build ./...passes