execution/execmodule: test EIP-7708 burn log when coinbase self-destructs#20416
Merged
Conversation
…lf-destructs Adds a regression test for #19951: when the coinbase is a contract that self-destructs during execution, EIP-7708 requires a Burn log for the residual priority fee credited after SELFDESTRUCT. The test pre-computes the CREATE address, sets it as coinbase, deploys a contract with init code `CALLER SELFDESTRUCT`, then verifies the receipt contains the correct Burn log and that the state root validates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AskAlexSharov
approved these changes
Apr 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test in execution/execmodule to ensure EIP-7708 burn logs are emitted when the block coinbase is a contract that self-destructs during transaction execution (covering the scenario described in #19951), and validates the resulting state root via insert+validate+FCU.
Changes:
- Introduces
TestEIP7708BurnLogWhenCoinbaseSelfDestructsto reproduce the “coinbase selfdestructs then receives priority fees” case. - Asserts the receipt includes the expected EIP-7708
Burn(address,uint256)log (system address, correct topic[1] coinbase, correct data amount). - Confirms the built block validates correctly (state root / FCU path).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lfdestruct test Count Burn and Transfer logs from SYSTEM_ADDRESS and assert exactly one Burn log and zero Transfer logs (zero-value CREATE should not emit a Transfer). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CALLER SELFDESTRUCT), then asserts the receipt contains the correct Burn log and the state root validatesfinalizeTxdirect path must also match when enabledN.B.
Should be already covered by ethereum/execution-specs#2106, but adding a block builder test for completness.