Skip to content

node: remove unused logger and test helper #18744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taratorio merged 2 commits into from
Jan 27, 2026
Merged

node: remove unused logger and test helper #18744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eb045e
node: remove unused logger and test helper
TaderMP007 Jan 21, 2026
bfdfb64
Fix gofmt formatting
TaderMP007 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions node/node_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,12 +401,3 @@ func TestLifecycleTerminationGuarantee(t *testing.T) {
delete(stopped, id)
}
}

func containsProtocol(stackProtocols []p2p.Protocol, protocol p2p.Protocol) bool {
for _, a := range stackProtocols {
if reflect.DeepEqual(a, protocol) {
return true
}
}
return false
}
7 changes: 3 additions & 4 deletions node/privateapi/mining.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,9 @@ func (s *MiningServer) BroadcastMinedBlock(block *types.Block) error {

// MinedBlockStreams - it's safe to use this class as non-pointer
type MinedBlockStreams struct {
chans map[uint]txpoolproto.Mining_OnMinedBlockServer
id uint
mu sync.Mutex
logger log.Logger
chans map[uint]txpoolproto.Mining_OnMinedBlockServer
id uint
mu sync.Mutex
}

func (s *MinedBlockStreams) Add(stream txpoolproto.Mining_OnMinedBlockServer) (remove func()) {
Expand Down
Loading