Skip to content

Remove redundant snapshot range sum check in publishable_check #18593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudeepdino008 merged 1 commit into from
Feb 4, 2026
Merged

Remove redundant snapshot range sum check in publishable_check #18593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions cmd/utils/app/publishable_check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,9 @@ func CheckFilesForSchema(schema state.SnapNameSchema, params CheckFilesParams) (
// - each data file has corresponding index/bt etc.1
// - versions: between min supported version and max
// - lastFileTo check
// - sum = maxTo check (probably redundant if no gaps/overlaps)

// collect all data files
dataFiles := make([]state.SnapInfo, 0)
sumRange := uint64(0)
if err := filepath.WalkDir(schema.DataDirectory(), func(path string, info fs.DirEntry, err error) error {
if err != nil {
if os.IsNotExist(err) { //it's ok if some file get removed during walk
Expand All @@ -61,7 +59,6 @@ func CheckFilesForSchema(schema state.SnapNameSchema, params CheckFilesParams) (
return nil
}

sumRange += res.To - res.From
dataFiles = append(dataFiles, *res)

return nil
Expand Down Expand Up @@ -89,10 +86,6 @@ func CheckFilesForSchema(schema state.SnapNameSchema, params CheckFilesParams) (
return 0, false, fmt.Errorf("last %s snapshot file must end at %d, found at %d (file: %s)", schema.DataTag(), params.checkLastFileTo, dataFiles[len(dataFiles)-1].To, dataFiles[len(dataFiles)-1].Name)
}

if sumRange != dataFiles[len(dataFiles)-1].To-dataFiles[0].From {
return 0, false, fmt.Errorf("sum of ranges of %s snapshot files (%d) does not match last 'to' value (%d)", schema.DataTag(), sumRange, dataFiles[len(dataFiles)-1].To)
}

prevFrom, prevTo := dataFiles[0].From, dataFiles[0].To
for i := 1; i < len(dataFiles); i++ {
df := dataFiles[i]
Expand Down
Loading