Conversation
yperbasis
changed the title
p2p into a module
AskAlexSharov
approved these changes
May 23, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ADD erigon-lib/go.sum erigon-lib/go.sum | ||
| ADD erigon-db/go.mod erigon-db/go.mod | ||
| ADD erigon-db/go.sum erigon-db/go.sum | ||
| ADD p2p/go.mod p2p/go.mod |
Check notice
Code scanning / SonarCloud
Prefer COPY over ADD for copying local resources Low
| ADD erigon-db/go.mod erigon-db/go.mod | ||
| ADD erigon-db/go.sum erigon-db/go.sum | ||
| ADD p2p/go.mod p2p/go.mod | ||
| ADD p2p/go.sum p2p/go.sum |
Check notice
Code scanning / SonarCloud
Prefer COPY over ADD for copying local resources Low
| ADD erigon-lib/go.sum erigon-lib/go.sum | ||
| ADD erigon-db/go.mod erigon-db/go.mod | ||
| ADD erigon-db/go.sum erigon-db/go.sum | ||
| ADD p2p/go.mod p2p/go.mod |
Check notice
Code scanning / SonarCloud
Prefer COPY over ADD for copying local resources Low
| ADD erigon-db/go.mod erigon-db/go.mod | ||
| ADD erigon-db/go.sum erigon-db/go.sum | ||
| ADD p2p/go.mod p2p/go.mod | ||
| ADD p2p/go.sum p2p/go.sum |
Check notice
Code scanning / SonarCloud
Prefer COPY over ADD for copying local resources Low
AskAlexSharov
pushed a commit
that referenced
this pull request
Jun 21, 2025
We [decided](#14554 (comment)) to reduce the number of modules. This partially reverts PR #14889. Part of #14554.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14554. See also ethereum/go-ethereum#30250