Skip to content

deps: update bitcoin-core/secp256k1 to v0.6.0#14117

Merged
yperbasis merged 7 commits into
mainfrom
update_secp256k1
Mar 17, 2025
Merged

deps: update bitcoin-core/secp256k1 to v0.6.0#14117
yperbasis merged 7 commits into
mainfrom
update_secp256k1

Conversation

@yperbasis
Copy link
Copy Markdown
Member

@yperbasis yperbasis commented Mar 7, 2025 •
edited
Loading

@yperbasis yperbasis linked an issue Mar 7, 2025 that may be closed by this pull request
Update secp256k1 #12626
Closed
@Giulio2002 Giulio2002 self-requested a review March 7, 2025 16:49
@Giulio2002
Copy link
Copy Markdown
Collaborator

Giulio2002 commented Mar 7, 2025

sorry - I, approved by accident

@yperbasis
Copy link
Copy Markdown
Member Author

yperbasis commented Mar 9, 2025 •
edited
Loading

Benchmarking on my Apple Silicon MacBook:

BEFORE:

goos: darwin
goarch: arm64
pkg: github.com/erigontech/erigon/core/vm
cpu: Apple M2 Max
BenchmarkPrecompiledEcrecover/-Gas=3000-12         	   17966	     67494 ns/op	      3000 gas/op	        44.44 mgas/s	     224 B/op	       4 allocs/op

AFTER:

BenchmarkPrecompiledEcrecover/-Gas=3000-12         	   54748	     21843 ns/op	      3000 gas/op	       137.3 mgas/s	     224 B/op	       4 allocs/op

@yperbasis
Copy link
Copy Markdown
Member Author

yperbasis commented Mar 16, 2025

Benchmarking on my Linux x86-64:

BEFORE:

goos: linux
goarch: amd64
pkg: github.com/erigontech/erigon/core/vm
cpu: 13th Gen Intel(R) Core(TM) i9-13900KS
BenchmarkPrecompiledEcrecover/-Gas=3000-32         	   40052	     30316 ns/op	      3000 gas/op	        98.95 mgas/s	     224 B/op	       4 allocs/op

AFTER:

BenchmarkPrecompiledEcrecover/-Gas=3000-32         	   60636	     19789 ns/op	      3000 gas/op	       151.6 mgas/s	     224 B/op	       4 allocs/op

@yperbasis yperbasis marked this pull request as ready for review March 17, 2025 15:38
@yperbasis yperbasis enabled auto-merge (squash) March 17, 2025 15:39
@yperbasis yperbasis requested review from somnergy and taratorio March 17, 2025 15:39
@yperbasis yperbasis merged commit 9fc26c5 into main Mar 17, 2025
@yperbasis yperbasis deleted the update_secp256k1 branch March 17, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@somnergy somnergy somnergy approved these changes

@taratorio taratorio taratorio approved these changes

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002

@chfast chfast Awaiting requested review from chfast

@AskAlexSharov AskAlexSharov Awaiting requested review from AskAlexSharov AskAlexSharov is a code owner

Assignees

No one assigned

Labels

performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update secp256k1

4 participants

@yperbasis @Giulio2002 @somnergy @taratorio