Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool: race in logging, part2 #13487

Merged
merged 3 commits into from
Jan 18, 2025
Merged

pool: race in logging, part2 #13487

merged 3 commits into from
Jan 18, 2025

Conversation

AskAlexSharov
Copy link
Collaborator

==================
WARNING: DATA RACE
Write at 0x00c029988f40 by goroutine 322:
  github.com/erigontech/erigon/txnprovider/txpool.(*bestSlice).UnsafeAdd()
      /home/ubuntu/erigon/txnprovider/txpool/queues.go:50 +0x444
  github.com/erigontech/erigon/txnprovider/txpool.(*PendingPool).Add()
      /home/ubuntu/erigon/txnprovider/txpool/pending_pool.go:97 +0x325
  github.com/erigontech/erigon/txnprovider/txpool.(*TxPool).promote()
      /home/ubuntu/erigon/txnprovider/txpool/pool.go:1819 +0x194d
  github.com/erigontech/erigon/txnprovider/txpool.(*TxPool).addTxns()
      /home/ubuntu/erigon/txnprovider/txpool/pool.go:1327 +0xd84
  github.com/erigontech/erigon/txnprovider/txpool.(*TxPool).processRemoteTxns()
      /home/ubuntu/erigon/txnprovider/txpool/pool.go:511 +0x7c7
  github.com/erigontech/erigon/txnprovider/txpool.(*TxPool).Run()
      /home/ubuntu/erigon/txnprovider/txpool/pool.go:1887 +0x9b2
  github.com/erigontech/erigon/eth.(*Ethereum).Start.func3()
      /home/ubuntu/erigon/eth/backend.go:1594 +0x7a
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/ubuntu/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91

Previous read at 0x00c029988f40 by goroutine 324:
  github.com/erigontech/erigon/txnprovider/txpool.(*TxPool).OnNewBlock()
      /home/ubuntu/erigon/txnprovider/txpool/pool.go:310 +0x3c4
  github.com/erigontech/erigon/txnprovider/txpool.(*Fetch).handleStateChangesRequest()
      /home/ubuntu/erigon/txnprovider/txpool/fetch.go:516 +0x47a
  github.com/erigontech/erigon/txnprovider/txpool.(*Fetch).handleStateChanges()
      /home/ubuntu/erigon/txnprovider/txpool/fetch.go:468 +0x2ad
  github.com/erigontech/erigon/txnprovider/txpool.(*Fetch).ConnectCore.func1()
      /home/ubuntu/erigon/txnprovider/txpool/fetch.go:124 +0xa4

also renamed coreDB to chainDB

@taratorio taratorio merged commit 4497748 into main Jan 18, 2025
12 of 13 checks passed
@taratorio taratorio deleted the pool_race2 branch January 18, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants