Restore stateless client prototype (without semi-stateless) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyAkhunov
commented
Oct 14, 2019
| // TestCopy tests that copying a statedb object indeed makes the original and | ||
| // the copy independent of each other. This test is a regression test against | ||
| // https://github.com/ethereum/go-ethereum/pull/15549. | ||
| func TestCopy(t *testing.T) { |
There was a problem hiding this comment.
Removed this test because it is the only place that uses tries concurrently, and therefore requires locking in trie_pruning.go, at a great performance cost
AlexeyAkhunov
commented
Oct 18, 2019
core/state/database.go
Outdated
| if err := tds.ResolveStateTrie(); err != nil { | ||
| return nil, err | ||
| } | ||
| roots, err := tds.computeTrieRoots(true) |
There was a problem hiding this comment.
Rename to updateStateTrie
AlexeyAkhunov
commented
Oct 18, 2019
core/state/database.go
Outdated
| } | ||
| } | ||
|
|
||
| func (tds *TrieDbState) ExtractTouches() [][]byte { | ||
| func (tds *TrieDbState) ExtractTouches() ([][]byte, [][]byte) { |
There was a problem hiding this comment.
Add names of the return values + comment
AlexeyAkhunov
commented
Oct 18, 2019
core/state/database.go
Outdated
|
|
||
| // forward is `true` if the function is used to progress the state forward (by adding blocks) | ||
| // forward is `false` if the function is used to rewind the state (for reorgs, for example) | ||
| func (tds *TrieDbState) computeTrieRoots(forward bool) ([]common.Hash, error) { |
There was a problem hiding this comment.
Rename to updateStateTrie
AlexeyAkhunov
commented
Oct 19, 2019
trie/proof_generator.go
Outdated
| // BlockWitnessBuilder accumulates data that can later be turned into a serialised | ||
| // version of the block witness | ||
| // All buffers are streams of CBOR-encoded items (not a CBOR array, but individual items back-to-back) | ||
| // `Keys` are binary strings | ||
| // `Values` are either binary strings or arrays of structures | ||
| // `Values` are either binary strings or integers (nonce) or big integers (balance) |
There was a problem hiding this comment.
Fix - nonces and balances now have their own tapes
AlexeyAkhunov
commented
Oct 19, 2019
| @@ -67,18 +65,13 @@ func runBlock(tds *state.TrieDbState, dbstate *state.Stateless, chainConfig *par | |||
| if err := statedb.CommitBlock(ctx, dbstate); err != nil { | |||
| return fmt.Errorf("commiting block %d failed: %v", block.NumberU64(), err) | |||
| } | |||
| if err := dbstate.CheckRoot(header.Root, checkRoot); err != nil { | |||
There was a problem hiding this comment.
Remove tds from the parameters of the runBlock function, it is not needed anymore
AlexeyAkhunov
commented
Oct 21, 2019
| if err := decoder.Decode(&lens); err != nil { | ||
| return nil, nil, err | ||
| } | ||
| hb := NewHashBuilder() |
There was a problem hiding this comment.
Comment about importance of order
AlexeyAkhunov
commented
Oct 21, 2019
trie/resolver.go
Outdated
| tr.a.EncodeForHashing(buf.B) | ||
| tr.hb.setKeyValue(skip, k, buf) | ||
| if tr.a.IsEmptyCodeHash() && tr.a.IsEmptyRoot() { | ||
| tr.fieldSet = 3 |
There was a problem hiding this comment.
Comments and constants
mandrigin
pushed a commit
that referenced
this pull request
Nov 4, 2019
BlinkyStitt
pushed a commit
to llamanodes/erigon
that referenced
this pull request
Jun 8, 2023
* support step-by-step stage sync * update sync logic
battlmonstr
pushed a commit
that referenced
this pull request
Sep 14, 2023
cffls
pushed a commit
to cffls/erigon
that referenced
this pull request
Feb 14, 2024
* fixes for handling scalable contract and block gas limit * allow a network with no L1 verifications to still be synced by another node * fixes to the datastream allowing another erigon node to sync
wtdcode
pushed a commit
to wtdcode/erigon
that referenced
this pull request
May 27, 2024
taratorio
pushed a commit
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Michele Modolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added necessary code to generate block witnesses in the new format (based on the stack machine with tapes).
Modified the prototype in
cmd/state/stateless.goto use the new format.Has not yet fixed writing out the stats (size of the witnesses and their components).