Skip to content

Use min/max/clear from go1.21 #10532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AskAlexSharov merged 3 commits into from
May 29, 2024
Merged

Use min/max/clear from go1.21 #10532

AskAlexSharov merged 3 commits into from
May 29, 2024

Conversation

@yperbasis
Copy link
Member

@yperbasis yperbasis commented May 28, 2024

@yperbasis yperbasis requested a review from Giulio2002 May 28, 2024 20:44
@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented May 29, 2024

FYI: I did (6 months ago) try to use clear on map[int]*data type. And it was very slow. Because it did try to do some GC-related things on * pointers. It was very visible on pprof. Maybe it will be improved in future versions of Go.
This PR seems doesn't have such cases.

@AskAlexSharov AskAlexSharov merged commit da059e5 into main May 29, 2024
@AskAlexSharov AskAlexSharov deleted the clear branch May 29, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov approved these changes

@battlmonstr battlmonstr Awaiting requested review from battlmonstr

@taratorio taratorio Awaiting requested review from taratorio taratorio is a code owner

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002 Giulio2002 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yperbasis @AskAlexSharov