Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not replace 'tween #23

Merged
merged 3 commits into from
May 6, 2017
Merged

Do not replace 'tween #23

merged 3 commits into from
May 6, 2017

Conversation

AGSPhoenix
Copy link

'Tween is incorrectly replaced. Doesn't affect most text on the web, but I recently read a short story with a character from the American South, and it got pretty butchered.

This patch uses a technique I stoleborrowed from this post on SE. It uses a clever regex to capture the ' and change the replacement output depending on whether it was detected.

I used the following as my test suite and it properly handles them all:

tween
tweens
between
tweener
trouble 'tween the two
Those tweens are ruining everything

If you have any questions or comments, fire away.

...and also properly handle plurals, since that's no longer handled
implicitly.
@ericwbailey
Copy link
Owner

ericwbailey commented May 6, 2017

Nice catch, thank you. Mind updating to fix the conflicts? I'll get it right in after.

@AGSPhoenix
Copy link
Author

Not sure if Github notifies when commits are added to a PR. In case it doesn't, poke.

@ericwbailey
Copy link
Owner

Ha, thanks!

@ericwbailey ericwbailey merged commit 1df5904 into ericwbailey:master May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants