Skip to content

Update renderOverlay name in docs #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2016
Merged

Update renderOverlay name in docs #91

merged 1 commit into from
Sep 18, 2016

Conversation

owencm
Copy link
Contributor

@owencm owencm commented Sep 18, 2016

Updating the docs to reflect that renderOverlay is now called renderHeader

@owencm owencm mentioned this pull request Sep 18, 2016
Open
@satya164
Copy link
Collaborator

Thanks :)

@satya164 satya164 merged commit e7bd08d into ericvicenti:master Sep 18, 2016
@jmurzy
Copy link

jmurzy commented Sep 18, 2016 •
edited
Loading

@satya164 This is incorrect. NavigationAnimatedView is replaced by NavigationTransitioner, and the last version, 0.29.2, that shipped with NavigationAnimatedView called it renderOverlay. I think @owencm confused NavigationAnimatedView with NavigationCardStack. Please see the related commit comments here.

Either way, the docs are out of date. 🤖

🍺

@satya164
Copy link
Collaborator

@jmurzy Oh. Sorry for not paying attention. Gotta revert this.

@satya164 satya164 mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owencm @satya164 @jmurzy