Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for React 15.
Changes made:
peerDependencies
devDependencies
react-dom/server
forrenderToStaticMarkup
instead ofreact
.Resolver.js
code seems to already be usingreact-dom/server
so no changes needed to be made thereTesting:
npm run test
npm run lint
because the peerDependencies ofeslint-config-future
are not installed (resulting in[email protected] requires a peer of [email protected] but none was installed
errors, etc..). And I was unable to manually install the required dependencies becauseeslint-config-future
wants[email protected]
but that version ofbabel-eslint
is broken due to this bug: TypeError: Cannot read property 'visitClass' of undefined babel/babel-eslint#243 No idea of linting will pass as a result of this.