Skip to content

Add CoffeeScript support & add synchronous foreground process support... #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Add CoffeeScript support & add synchronous foreground process support... #7

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
33171d6
Add ability to use a custom command to run the express server
rehno-lindeque Jun 3, 2013
0981acf
Stop the server on SIGINT
rehno-lindeque Jun 4, 2013
afcae22
Foreground express server waits for done signal
rehno-lindeque Jun 4, 2013
7865a8e
Simplify the termination logic and distinguish between the grunt task…
rehno-lindeque Jun 4, 2013
69fc63a
Merge pull request #1 from circuithub/master
rehno-lindeque Jun 4, 2013
489efdf
Change convention for assigning local this and change port assignment…
rehno-lindeque Jun 26, 2013
364f5ed
Merge branch 'master' of github.com:rehno-lindeque/grunt-express-server
rehno-lindeque Jun 26, 2013
8c41039
Use the correct grunt method for extend and remember to declare the s…
rehno-lindeque Jun 26, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions tasks/lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,27 @@ module.exports = function(grunt) {
var done = null;
var server = null; // Store server between live reloads to close/restart express

var finished = function() {
var taskFinished = function() {
if (done) {
//grunt.log.writeln('Task finished'.green);
done();

done = null;
}
};
var processFinished = function() {
//grunt.log.writeln('Process finished'.green);
server = null;
taskFinished();
};

return {
start: function(options) {
var _this = this;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common convention is to call this self, at least in grunt & yeoman.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was wondering what the norm is

if (server) {
this.stop();

if (grunt.task.current.flags.stop) {
finished();

return;
}
};
Expand All @@ -37,51 +42,46 @@ module.exports = function(grunt) {
done = grunt.task.current.async();

// Set PORT for new processes
// TODO: Shouldn't the port be set on server.env.PORT instead?
process.env.PORT = options.port;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you know what, you're right! A few lines below it has env: process.env, so it should be the same, but I'd rather use the proper variable.


// Spawn the express server
server = grunt.util.spawn({
cmd: (options.cmd || process.argv[0]),
args: options.args,
env: process.env,
fallback: options.fallback
}, options.error);

// Set up signal handlers for the child (server) & parent processes
server.once('exit', processFinished);
process.once('SIGINT', function(){ _this.stop('SIGINT'); });
process.once('SIGTERM', function(){ _this.stop('SIGTERM'); });
process.once('exit', this.stop);

server.stdout.pipe(process.stdout);
server.stderr.pipe(process.stderr);

// Delay / response detection for a server running as a background process
if (options.background) {
server = grunt.util.spawn({
cmd: process.argv[0],
args: options.args,
env: process.env,
fallback: options.fallback
}, options.error);

if (options.delay) {
setTimeout(finished, options.delay);
setTimeout(taskFinished, options.delay);
}

if (options.output) {
server.stdout.on('data', function(data){
var message = "" + data;
var regex = new RegExp(options.output, "gi");
if (message.match(regex)) finished();
if (message.match(regex)) taskFinished();
});
}

server.stdout.pipe(process.stdout);
server.stderr.pipe(process.stderr);
} else {
// Server is ran in current process
server = require(options.script);

finished();
}

process.on('exit', finished);
process.on('exit', this.stop);
},

stop: function() {
stop: function(signal) {
if (server) {
grunt.log.writeln('Stopping'.red + ' Express server');

server.kill('SIGTERM');
process.removeAllListeners();
server = null;
server.kill(signal? signal : 'SIGTERM');
};

finished();
}
};
};