Add module to available options #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for grunt targets that do not match the angular module name.
| base: 'src/views', // $templateCache ID will be relative to this folder | ||
| prepend: '/static/assets/' // (Optional) Prepend path to $templateCache ID | ||
| prepend: '/static/assets/', // (Optional) Prepend path to $templateCache ID | ||
| module: 'App' // (Optional) The module the templates will be added to, defaults to target if not present ('build' in this case) |
There was a problem hiding this comment.
The whitespace nazi in me wants to align the // part, but I can't argue with progress!
There was a problem hiding this comment.
I know what you mean. I'm a right margin nut so the whole line was making me hyperventilate.
There was a problem hiding this comment.
Sounds like we should work together :)
I ended up splitting it up into 2 lines for v0.3.2, so we both win!
ericclemmons
added a commit
that referenced
this pull request
Apr 24, 2013
Add module to available options
|
Thanks for the awesome PR! |
|
And thank you for the speedy merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This commit allows for grunt targets that do not match the angular module name. It's fully backwards compatible, includes tests, and a README update.
Let me know if you have any concerns or change requests.
Cheers,
Sid