Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip merging source files to a single destination file #114

Merged
merged 3 commits into from
Aug 9, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,15 @@ module.exports = function(grunt) {
options: {
usemin: 'usemin/all.js'
}
},

// bunch of files at different level in a directory (unmerged in dest)
unmerged_files: {
src: 'test/fixtures/unmerged/**/*.html',
dest: 'tmp/unmerged/',
options: {
merge: false
}
}
}
});
Expand Down
27 changes: 23 additions & 4 deletions tasks/angular-templates.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ module.exports = function(grunt) {
url: function(path) { return path; },
usemin: null,
append: false,
quotes: 'double'
quotes: 'double',
merge: true
});

grunt.verbose.writeflags(options, 'Options');
Expand All @@ -50,16 +51,34 @@ module.exports = function(grunt) {
var compiled = [];

for (var module in modules) {
compiled.push(compiler.compile(module, modules[module]));
if (options.merge) {
compiled.push(compiler.compile(module, modules[module]));
} else {
//Compiling each file to the same module
for (var j = 0; j < file.src.length; j++) {
compiled.push(compiler.compile(module, [file.src[j]]));
}
}
}

if (options.append){
fs.appendFileSync(file.dest, compiled.join('\n'));
grunt.log.writeln('File ' + file.dest.cyan + ' updated.');
}
else{
grunt.file.write(file.dest, compiled.join('\n'));
grunt.log.writeln('File ' + file.dest.cyan + ' created.');
if (options.merge) {
grunt.file.write(file.dest, compiled.join('\n'));
grunt.log.writeln('File ' + file.dest.cyan + ' created.');
} else {
//Writing compiled file to the same relative location as source, without merging them together
for (var i = 0; i < compiled.length; i++) {
var dest = file.dest + file.src[i];
//Change extension to js from html/htm
dest = dest.replace(/(html|htm)$/i, "js");
grunt.file.write(dest, compiled[i]);
grunt.log.writeln('File ' + dest.cyan + ' created.');
}
}
}


Expand Down
11 changes: 11 additions & 0 deletions test/angular-templates_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,17 @@ exports.ngtemplates = {

test.equal(expected, actual);
test.done();
},

unmerged_files: function(test) {
test.expect(5);

test.equal(grunt.file.read('tmp/unmerged/test/fixtures/unmerged/undefined.js'), grunt.file.read('test/expected/unmerged_files/undefined.js'));
test.equal(grunt.file.read('tmp/unmerged/test/fixtures/unmerged/usemin.js'), grunt.file.read('test/expected/unmerged_files/usemin.js'));
test.equal(grunt.file.read('tmp/unmerged/test/fixtures/unmerged/level2/empty.js'), grunt.file.read('test/expected/unmerged_files/empty.js'));
test.equal(grunt.file.read('tmp/unmerged/test/fixtures/unmerged/level2/html5.js'), grunt.file.read('test/expected/unmerged_files/html5.js'));
test.equal(grunt.file.read('tmp/unmerged/test/fixtures/unmerged/level2/level3/one.js'), grunt.file.read('test/expected/unmerged_files/one.js'));
test.done();
}

};
8 changes: 8 additions & 0 deletions test/expected/unmerged_files/empty.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
angular.module('unmerged_files').run(['$templateCache', function($templateCache) {
'use strict';

$templateCache.put('test/fixtures/unmerged/level2/empty.html',
""
);

}]);
20 changes: 20 additions & 0 deletions test/expected/unmerged_files/html5.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
angular.module('unmerged_files').run(['$templateCache', function($templateCache) {
'use strict';

$templateCache.put('test/fixtures/unmerged/level2/html5.html',
"<div>\n" +
" <span>\n" +
" Self-closing, sucka!\n" +
" <br>\n" +
" <img src='path/to/img'> Howdy\n" +
"</div>\n" +
"\n" +
"<hr>\n" +
"\n" +
"<table>\n" +
" <tr>\n" +
" <td>\n" +
" Howdy\n"
);

}]);
16 changes: 16 additions & 0 deletions test/expected/unmerged_files/one.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
angular.module('unmerged_files').run(['$templateCache', function($templateCache) {
'use strict';

$templateCache.put('test/fixtures/unmerged/level2/level3/one.html',
"<h1>One</h1>\n" +
"\n" +
"<p class=\"\">I am one.</p>\n" +
"\n" +
"<script type=\"text/javascript\">\n" +
" // Test\n" +
" /* comments */\n" +
" var foo = 'bar';\n" +
"</script>\n"
);

}]);
16 changes: 16 additions & 0 deletions test/expected/unmerged_files/undefined.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
angular.module('unmerged_files').run(['$templateCache', function($templateCache) {
'use strict';

$templateCache.put('test/fixtures/unmerged/undefined.html',
"<h1>Undefined</h1>\n" +
"\n" +
"<p class=\"\">I am undefined.</p>\n" +
"\n" +
"<script type=\"text/javascript\">\n" +
" // Test\n" +
" /* comments */\n" +
" var foo = 'bar';\n" +
"</script>\n"
);

}]);
37 changes: 37 additions & 0 deletions test/expected/unmerged_files/usemin.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
angular.module('unmerged_files').run(['$templateCache', function($templateCache) {
'use strict';

$templateCache.put('test/fixtures/unmerged/usemin.html',
"<!DOCTYPE html>\n" +
" <head>\n" +
" <link rel=\"stylesheet\" href=\"styles/main.css\">\n" +
" <script src=\"scripts/vendor/modernizr.min.js\"></script>\n" +
" </head>\n" +
" <body>\n" +
"\n" +
" <!-- build:js usemin/foo.js -->\n" +
" <script src=\"usemin/foo.js\"></script>\n" +
" <!-- endbuild -->\n" +
"\n" +
" <!-- build:js usemin/bar.js -->\n" +
" <script src=\"usemin/bar.js\"></script>\n" +
" <!-- endbuild -->\n" +
"\n" +
" <!-- build:js usemin/all.js -->\n" +
" <script src=\"usemin/foo.js\"></script>\n" +
" <script src=\"usemin/bar.js\"></script>\n" +
" <!-- endbuild -->\n" +
"\n" +
" <!-- build:js duplicate/usemin/all.js -->\n" +
" <script src=\"usemin/foo.js\"></script>\n" +
" <script src=\"usemin/bar.js\"></script>\n" +
" <!-- endbuild -->\n" +
"\n" +
" <!-- build:css usemin/bar.css -->\n" +
" <script src=\"usemin/bar.css\"></script>\n" +
" <!-- endbuild -->\n" +
"</body>\n" +
"</html>\n"
);

}]);
Empty file.
13 changes: 13 additions & 0 deletions test/fixtures/unmerged/level2/html5.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<div>
<span>
Self-closing, sucka!
<br>
<img src='path/to/img'> Howdy
</div>

<hr>

<table>
<tr>
<td>
Howdy
9 changes: 9 additions & 0 deletions test/fixtures/unmerged/level2/level3/one.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<h1>One</h1>

<p class="">I am one.</p>

<script type="text/javascript">
// Test
/* comments */
var foo = 'bar';
</script>
9 changes: 9 additions & 0 deletions test/fixtures/unmerged/undefined.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<h1>Undefined</h1>

<p class="">I am undefined.</p>

<script type="text/javascript">
// Test
/* comments */
var foo = 'bar';
</script>
30 changes: 30 additions & 0 deletions test/fixtures/unmerged/usemin.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<!DOCTYPE html>
<head>
<link rel="stylesheet" href="styles/main.css">
<script src="scripts/vendor/modernizr.min.js"></script>
</head>
<body>

<!-- build:js usemin/foo.js -->
<script src="usemin/foo.js"></script>
<!-- endbuild -->

<!-- build:js usemin/bar.js -->
<script src="usemin/bar.js"></script>
<!-- endbuild -->

<!-- build:js usemin/all.js -->
<script src="usemin/foo.js"></script>
<script src="usemin/bar.js"></script>
<!-- endbuild -->

<!-- build:js duplicate/usemin/all.js -->
<script src="usemin/foo.js"></script>
<script src="usemin/bar.js"></script>
<!-- endbuild -->

<!-- build:css usemin/bar.css -->
<script src="usemin/bar.css"></script>
<!-- endbuild -->
</body>
</html>