Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Starter App Cleanup #83

Merged
merged 25 commits into from
Apr 30, 2013
Merged

[WIP] Starter App Cleanup #83

merged 25 commits into from
Apr 30, 2013

Conversation

kwhitley
Copy link
Contributor

Refs #35

TODO

  • Convert home to show server/client installed modules
  • Configure and test regarde targets (I don't believe the root folder path watch target works)
  • Remove any extra tasks
  • Fix angular templates error in dev mode

@ghost ghost assigned kwhitley Apr 28, 2013
@kwhitley
Copy link
Contributor Author

Still a [WIP]... have to run out for a bit but can continue tonight.

@ericclemmons
Copy link
Owner

I was going to keep working on it for you, just wanted to catch up to where you were!

@kwhitley
Copy link
Contributor Author

Cool! You'll make faster progress anyway :) see todos for issues I know of so far...

@ericclemmons
Copy link
Owner

Fixed several issues that we've been having for a while (see commits).

Not sure what the problem is with angular templates in dev mode. It would always 404 since the file doesn't exist. Unless I approved the following PR to automatically add it to the concat task:

ericclemmons/grunt-angular-templates#17

@ericclemmons
Copy link
Owner

Oh yea, here's how it looks right now:

Genesis Skeleton

@kwhitley
Copy link
Contributor Author

Hell yes! Looks beautiful! 👍

@ericclemmons
Copy link
Owner

Holy crap, there will be a demo tomorrow!!

@kwhitley
Copy link
Contributor Author

$ grunt server
Running "clean:dist" (clean) task

Running "jshint:files" (jshint) task
>> 9 files lint free.

Running "karma:unit" (karma) task
INFO [karma]: Karma server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
ERROR [launcher]: Cannot start PhantomJS
    execvp(): No such file or directory

INFO [launcher]: Trying to start PhantomJS again.
ERROR [launcher]: Cannot start PhantomJS
    execvp(): No such file or directory

INFO [launcher]: Trying to start PhantomJS again.
ERROR [launcher]: Cannot start PhantomJS
    execvp(): No such file or directory

Warning: Task "karma:unit" failed. Use --force to continue.

Aborted due to warnings.

@kwhitley
Copy link
Contributor Author

If this will run by default, may want to include a brew install phantomjs line to the README.md.

@ericclemmons
Copy link
Owner

I'd be interested in running this purely through jasmine, and letting the user choose to use phantomjs vs chrome vs ie.

Maybe there's a grunt-jasmine we should be running through karma, or separately?

Eric Clemmons
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Monday, April 29, 2013 at 12:19 PM, Kevin Whitley wrote:

If this will run by default, may want to include a brew update && brew install phantomjs line to the README.md.


Reply to this email directly or view it on GitHub (#83 (comment)).

@ericclemmons
Copy link
Owner

Ok, I think I'm done. I'm really proud of the work we did on this, and I think it's an awesome starter kit that solves sooooo many problems.

I'm eager to update Genesis Skeleton's webpage to match. Plus, I think I should kill the yeoman installer, too. We're not doing Yeoman.

ericclemmons added a commit that referenced this pull request Apr 30, 2013
@ericclemmons ericclemmons merged commit d01c360 into master Apr 30, 2013
@ericclemmons ericclemmons deleted the feature/35-starter-app branch April 30, 2013 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants