Skip to content

[v6.0] Accumulate ErgoTree deserialization cost #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 2, 2024
Merged

[v6.0] Accumulate ErgoTree deserialization cost #938

merged 5 commits into from
Aug 2, 2024

Conversation

@sethdusek
Copy link
Contributor

@sethdusek sethdusek commented Nov 22, 2023

For #846

I've accumulated the deserialization cost into the total cost and updated all the relevant test cases with costs for all ErgoTree versions when V3 is activated.

@sethdusek sethdusek marked this pull request as draft November 22, 2023 13:58
@sethdusek
Copy link
Contributor Author

sethdusek commented Nov 23, 2023

Should I rebase this to #930?

Also are there any formatting guidelines? There doesn't seem to be any mention of proper formatting in CONTRIBUTING.md.

@sethdusek sethdusek changed the base branch from develop to v6.0.0 November 28, 2023 21:08
@sethdusek sethdusek marked this pull request as ready for review November 28, 2023 23:54
@sethdusek
ScriptVersionSwitchSpecification change rules 19,20 from skip-accept …
bd61125 
…to full V6 Validation + Add new rule tests for BlockVer V4/Script v3
@sethdusek
Copy link
Contributor Author

sethdusek commented Dec 21, 2023

CI should be good to go now! Added new version tests for V3, please take a look at those as well

@kushti kushti added the 6.0 label Dec 22, 2023
@kushti kushti added this to the v6.0 milestone Dec 22, 2023
@kushti kushti mentioned this pull request Dec 22, 2023
Merged
@kushti kushti requested a review from aslesarenko December 27, 2023 13:13
@sethdusek
Copy link
Contributor Author

sethdusek commented Jan 19, 2024

Please re-run CI, I believe this CI failure was due to an issue in the underlying branch and not this PR itself. Github doesn't seem to automatically re-run CI for PRs when the base branch changes

@aslesarenko
Copy link
Member

aslesarenko commented Jan 22, 2024 •
edited
Loading

Github doesn't seem to automatically re-run CI for PRs when the base branch changes

@sethdusek, yes, because changing the base branch doesn't change the commit which is tested.
Also, "re-run" command in somehow not available in the logs.

@kushti
Copy link
Member

kushti commented Jan 31, 2024 •
edited
Loading

Indeed, ErgoTreeSerializerSpecification is failing, which is unlikely touched by this PR and locally tests are passed

@kushti
Copy link
Member

kushti commented Jan 31, 2024

@aslesarenko please review

aslesarenko
aslesarenko requested changes Jan 31, 2024
View reviewed changes
@kushti kushti merged commit eb219dd into ergoplatform:v6.0.0 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aslesarenko aslesarenko aslesarenko requested changes

@kushti kushti kushti approved these changes

Assignees

No one assigned

Labels

6.0

Projects

None yet

Milestone

v6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sethdusek @aslesarenko @kushti