[6.0] Improve collections equality #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslesarenko
approved these changes
Oct 16, 2024
Member
aslesarenko
left a comment
aslesarenko
left a comment
There was a problem hiding this comment.
LGTM, but please address the comments
| java.util.Objects.deepEquals(obj.toArray, this.toArray) | ||
| case obj: PairColl[_, _] if obj.tItem == this.tItem => | ||
| if(VersionContext.current.isV6SoftForkActivated) { | ||
| java.util.Objects.deepEquals(obj.toArray, this.toArray) |
Member
There was a problem hiding this comment.
the obj.toArray will lead to many allocations (one for the array, and one for each pair). It is better to avoid it allocations in equals. Here it can be done by accessing obj.ls, obj.rs and comparing with this.toArray in a cfor loop.
| ls == that.ls && rs == that.rs | ||
| case that: CollOverArray[_] if that.tItem == this.tItem => | ||
| if (VersionContext.current.isV6SoftForkActivated) { | ||
| java.util.Objects.deepEquals(that.toArray, this.toArray) |
Member
There was a problem hiding this comment.
The comparison loop above (once implemented) can be reused here to avoid allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, PairOfColl made equal with CollOverArray (when contents is the same), starting from 6.0 version of the protocol
close #909