-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations #752
Merged
Merged
Optimizations #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reworks how ergotree-interpreter stores data and reduces cloning/heap allocations significantly. Variables can now borrow from their context instead of cloning. Instead of deep-copying types repeatedly we wrap types in Arc<T>. Also optimized certain interpreter ops like Coll.length
Pull Request Test Coverage Report for Build 9447878182Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9531205479Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9531717301Details
💛 - Coveralls |
kushti
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #737 and #738.
Reworked how the interpreter stores data, allowing it to borrow from context or store it in an Arc to avoid cloning for repeated uses of the same environment variable. Also optimized certain interpreter ops to reduce cloning (Coll.size, Coll.indices, etc).
This change also makes context creation much cheaper and re-uses context across inputs, making sigma-rust significantly faster for signing/validating transactions with a large number of inputs. Benchmarks will be posted below