-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset interpreter env after lambda call #728
Conversation
Pull Request Test Coverage Report for Build 6503468789
💛 - Coveralls |
@@ -11,14 +12,31 @@ use crate::eval::Evaluable; | |||
|
|||
impl Evaluable for BlockValue { | |||
fn eval(&self, env: &mut Env, ctx: &mut EvalContext) -> Result<Value, EvalError> { | |||
let mut existing_variables = HashMap::new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code breaks the diag_on_reduced_to_false
test. We might need to make an exception for the global BlockValue
of a script, and do not delete introduced ValId
s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this! Ideally, yes. If not, feel free to make the test ignored/commented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem! Made the change so ValDef
s in global block persist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thank you!
Close #730.