Add N2T contracts #35
Conversation
oskin1
left a comment
oskin1
left a comment
There was a problem hiding this comment.
Also, please add yourself to the authors list.
| { | ||
| val InitiallyLockedLP = 0x7fffffffffffffffL | ||
| val FeeDenom = 1000 | ||
| val minStorageRent = 10000000L // this many number of nanoErgs are going to be permanently locked |
There was a problem hiding this comment.
Why permanently locked? Why LP can't redeem all the liquidity and destroy the pool? Otherwise unless we consider this locked reserves in deposit / redeem formulas there will be some portion of LP tokens that can never be returned.
There was a problem hiding this comment.
Redeem complete liquidity and destroying the pool can never happen even in the T2T contracts. The moment you have successor condition, the contract will fail if there is no successor, and so we will just let that small amount of LP stuck till miner can claim it. If we can modify the normal T2T contracts to accommodate destruction, we can port same logic here. We can think of adding more checks to allow complete LP redemption but that will make it more complex, so I suggest we leave it.
Remove reference to UniSwap 1.0
Remove reference to UniSwap 1.0
Contracts for LP and Sell Ergs.
Remaining contracts WIP