Fix typos #464
Merged
Fix typos #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
Jan 8, 2024
| @@ -20,6 +20,6 @@ final class InvalidPhaseIdentifier extends \InvalidArgumentException | |||
| { | |||
| public static function blankOrEmpty(): self | |||
| { | |||
| return new self('Value can not be blank or empty.'); | |||
| return new self('Value cannot be blank or empty.'); | |||
There was a problem hiding this comment.
Though technically not wrong, to my knowledge "cannot" is the preferred form.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
=========================================
Coverage 69.86% 69.86%
Complexity 110 110
=========================================
Files 26 26
Lines 521 521
=========================================
Hits 364 364
Misses 157 157 ☔ View full report in Codecov by Sentry. |
localheinz
approved these changes
Jan 30, 2024
|
Thank you, @HypeMC! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes some typos.