Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not report maximum duration for slow tests #450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

localheinz
Copy link
Member

This pull request

  • stops reporting the maximum duration for slow tests

Replaces #379.

/cc @mvorisek

@localheinz localheinz self-assigned this Dec 23, 2023
@localheinz localheinz force-pushed the fix/maximum-duration branch 3 times, most recently from 957b2c1 to b5cb5c6 Compare December 23, 2023 21:18
Co-authored-by: Andreas Möller <[email protected]>
Co-authored-by: Michael Voříšek <[email protected]>
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a3cae4) 69.86% compared to head (6444621) 69.18%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #450      +/-   ##
============================================
- Coverage     69.86%   69.18%   -0.69%     
+ Complexity      110      109       -1     
============================================
  Files            26       26              
  Lines           521      503      -18     
============================================
- Hits            364      348      -16     
+ Misses          157      155       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mvorisek
Copy link
Contributor

I prefer to close this PR in favor of #396. Non-default duration is good to be reported to let the user know that some value like 61 seconds is not too much, as 60 seconds was max. passing duration for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants