Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rename subscribers #422

Merged
merged 1 commit into from
Dec 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions psalm-baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
<code>($durationInMilliseconds - $hoursInMilliseconds - $minutesInMilliseconds) / 1_000</code>
</InvalidOperand>
</file>
<file src="src/Subscriber/TestPassedSubscriber.php">
<file src="src/Subscriber/Test/PassedSubscriber.php">
<UndefinedClass>
<code>Event\Test\PassedSubscriber</code>
</UndefinedClass>
<UnusedClass>
<code>TestPassedSubscriber</code>
<code>PassedSubscriber</code>
</UnusedClass>
<UnusedParam>
<code>$collector</code>
Expand All @@ -35,24 +35,24 @@
<code>$timeKeeper</code>
</UnusedParam>
</file>
<file src="src/Subscriber/TestPreparedSubscriber.php">
<file src="src/Subscriber/Test/PreparedSubscriber.php">
<UndefinedClass>
<code>Event\Test\PreparedSubscriber</code>
</UndefinedClass>
<UnusedClass>
<code>TestPreparedSubscriber</code>
<code>PreparedSubscriber</code>
</UnusedClass>
<UnusedParam>
<code>$event</code>
<code>$timeKeeper</code>
</UnusedParam>
</file>
<file src="src/Subscriber/TestRunnerExecutionFinishedSubscriber.php">
<file src="src/Subscriber/TestRunner/ExecutionFinishedSubscriber.php">
<UndefinedClass>
<code>Event\TestRunner\ExecutionFinishedSubscriber</code>
</UndefinedClass>
<UnusedClass>
<code>TestRunnerExecutionFinishedSubscriber</code>
<code>ExecutionFinishedSubscriber</code>
</UnusedClass>
<UnusedParam>
<code>$collector</code>
Expand Down
6 changes: 3 additions & 3 deletions src/Extension.php
Original file line number Diff line number Diff line change
Expand Up @@ -206,13 +206,13 @@
);

$facade->registerSubscribers(
new Subscriber\TestPreparedSubscriber($timeKeeper),
new Subscriber\TestPassedSubscriber(
new Subscriber\Test\PreparedSubscriber($timeKeeper),
new Subscriber\Test\PassedSubscriber(

Check warning on line 210 in src/Extension.php

View check run for this annotation

Codecov / codecov/patch

src/Extension.php#L209-L210

Added lines #L209 - L210 were not covered by tests
$maximumDuration,
$timeKeeper,
$collector,
),
new Subscriber\TestRunnerExecutionFinishedSubscriber(
new Subscriber\TestRunner\ExecutionFinishedSubscriber(

Check warning on line 215 in src/Extension.php

View check run for this annotation

Codecov / codecov/patch

src/Extension.php#L215

Added line #L215 was not covered by tests
$collector,
$reporter,
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* @see https://github.com/ergebnis/phpunit-slow-test-detector
*/

namespace Ergebnis\PHPUnit\SlowTestDetector\Subscriber;
namespace Ergebnis\PHPUnit\SlowTestDetector\Subscriber\Test;

use Ergebnis\PHPUnit\SlowTestDetector\Attribute;
use Ergebnis\PHPUnit\SlowTestDetector\Collector;
Expand All @@ -27,7 +27,7 @@
/**
* @internal
*/
final class TestPassedSubscriber implements Event\Test\PassedSubscriber
final class PassedSubscriber implements Event\Test\PassedSubscriber
{
private Collector\Collector $collector;
private TimeKeeper $timeKeeper;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* @see https://github.com/ergebnis/phpunit-slow-test-detector
*/

namespace Ergebnis\PHPUnit\SlowTestDetector\Subscriber;
namespace Ergebnis\PHPUnit\SlowTestDetector\Subscriber\Test;

use Ergebnis\PHPUnit\SlowTestDetector\PhaseIdentifier;
use Ergebnis\PHPUnit\SlowTestDetector\Time;
Expand All @@ -21,7 +21,7 @@
/**
* @internal
*/
final class TestPreparedSubscriber implements Event\Test\PreparedSubscriber
final class PreparedSubscriber implements Event\Test\PreparedSubscriber
{
private TimeKeeper $timeKeeper;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* @see https://github.com/ergebnis/phpunit-slow-test-detector
*/

namespace Ergebnis\PHPUnit\SlowTestDetector\Subscriber;
namespace Ergebnis\PHPUnit\SlowTestDetector\Subscriber\TestRunner;

use Ergebnis\PHPUnit\SlowTestDetector\Collector;
use Ergebnis\PHPUnit\SlowTestDetector\Reporter;
Expand All @@ -20,7 +20,7 @@
/**
* @internal
*/
final class TestRunnerExecutionFinishedSubscriber implements Event\TestRunner\ExecutionFinishedSubscriber
final class ExecutionFinishedSubscriber implements Event\TestRunner\ExecutionFinishedSubscriber
{
private Reporter\Reporter $reporter;
private Collector\Collector $collector;
Expand Down