Fix: Clean up tests

ergebnis · Dec 4, 2023 · 0e9bd15 · 0e9bd15
1 parent 5d7c06e
commit 0e9bd15
Show file tree

Hide file tree

Showing 15 changed files with 846 additions and 517 deletions.
diff --git a/test/EndToEnd/Version10/CustomConfiguration/SleeperTest.php b/test/EndToEnd/Version10/CustomConfiguration/SleeperTest.php
@@ -13,179 +13,15 @@
 
 namespace Ergebnis\PHPUnit\SlowTestDetector\Test\EndToEnd\Version10\CustomConfiguration;
 
-use Ergebnis\PHPUnit\SlowTestDetector\Attribute;
 use Ergebnis\PHPUnit\SlowTestDetector\Test;
 use PHPUnit\Framework;
 
 #[Framework\Attributes\CoversClass(Test\Fixture\Sleeper::class)]
 final class SleeperTest extends Framework\TestCase
 {
-    use Test\Util\Helper;
-
-    public function testSleeperDoesNotSleepAtAll(): void
-    {
-        $milliseconds = 0;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    /**
-     * This DocBlock is intentionally left without a useful comment or annotation.
-     */
-    public function testSleeperSleepsWithDocBlockWithoutSlowThresholdAnnotation(): void
-    {
-        $milliseconds = 90;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    /**
-     * @maximumDuration 3.14
-     */
-    public function testSleeperSleepsWithDocBlockWithMaximumDurationAnnotationWhereValueIsNotAnInt(): void
-    {
-        $milliseconds = 110;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    /**
-     * @maximumDuration 140
-     */
-    public function testSleeperSleepsShorterThanMaximumDurationFromMaximumDurationAnnotation(): void
-    {
-        $milliseconds = 130;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    /**
-     * @maximumDuration 150
-     */
-    public function testSleeperSleepsLongerThanMaximumDurationFromMaximumDurationAnnotation(): void
-    {
-        $milliseconds = 150;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    /**
-     * @maximumDuration 160
-     *
-     * @slowThreshold 120
-     */
-    public function testSleeperSleepsLongerThanMaximumDurationFromMaximumDurationAnnotationWhenSlowThresholdAnnotationIsPresentAfterMaximumDuration(): void
-    {
-        $milliseconds = 170;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    /**
-     * @slowThreshold 120
-     *
-     * @maximumDuration 180
-     */
-    public function testSleeperSleepsLongerThanMaximumDurationFromMaximumDurationAnnotationWhenSlowThresholdAnnotationIsPresentBeforeMaximumDuration(): void
-    {
-        $milliseconds = 200;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    /**
-     * @see https://github.com/johnkary/phpunit-speedtrap/blob/1.0/src/JohnKary/PHPUnit/Listener/SpeedTrapListener.php#L309-L331
-     *
-     * @slowThreshold 3.14
-     */
-    public function testSleeperSleepsWithDocBlockWithSlowThresholdAnnotationWhereValueIsNotAnInt(): void
-    {
-        $milliseconds = 40;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    /**
-     * @see https://github.com/johnkary/phpunit-speedtrap/blob/1.0/src/JohnKary/PHPUnit/Listener/SpeedTrapListener.php#L309-L331
-     *
-     * @slowThreshold 100
-     */
-    public function testSleeperSleepsShorterThanMaximumDurationFromSlowThresholdAnnotation(): void
-    {
-        $milliseconds = 80;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    /**
-     * @see https://github.com/johnkary/phpunit-speedtrap/blob/1.0/src/JohnKary/PHPUnit/Listener/SpeedTrapListener.php#L309-L331
-     *
-     * @slowThreshold 200
-     */
-    public function testSleeperSleepsLongerThanMaximumDurationFromSlowThresholdAnnotation(): void
+    #[Framework\Attributes\DataProvider('provideMillisecondsGreaterThanMaximumDurationFromXmlConfiguration')]
+    public function testSleeperSleepsLongerThanMaximumDurationFromXmlConfigurationWithDataProvider(int $milliseconds): void
     {
-        $milliseconds = 220;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    #[Attribute\MaximumDuration(140)]
-    public function testSleeperSleepsShorterThanMaximumDurationFromMaximumDurationAttribute(): void
-    {
-        $milliseconds = 130;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
-
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
-    }
-
-    #[Attribute\MaximumDuration(160)]
-    public function testSleeperSleepsLongerThanMaximumDurationFromMaximumDurationAttribute(): void
-    {
-        $milliseconds = 160;
-
         $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
 
         $sleeper->sleep();
@@ -194,17 +30,20 @@ public function testSleeperSleepsLongerThanMaximumDurationFromMaximumDurationAtt
     }
 
     /**
-     * @maximumDuration 20
+     * @return \Generator<int, array{0: int}>
      */
-    #[Attribute\MaximumDuration(50)]
-    public function testSleeperSleepsShorterThanMaximumDurationFromMaximumDurationAttributeWhenMaximumDurationAnnotationIsPresent(): void
+    public static function provideMillisecondsGreaterThanMaximumDurationFromXmlConfiguration(): iterable
     {
-        $milliseconds = 40;
-
-        $sleeper = Test\Fixture\Sleeper::fromMilliseconds($milliseconds);
+        $values = \range(
+            300,
+            500,
+            50,
+        );
 
-        $sleeper->sleep();
-
-        self::assertSame($milliseconds, $sleeper->milliseconds());
+        foreach ($values as $value) {
+            yield $value => [
+                $value,
+            ];
+        }
     }
 }
diff --git a/test/EndToEnd/Version10/CustomConfiguration/phpunit.xml b/test/EndToEnd/Version10/CustomConfiguration/phpunit.xml
@@ -18,7 +18,7 @@
     <extensions>
         <bootstrap class="Ergebnis\PHPUnit\SlowTestDetector\Extension">
             <parameter name="maximum-count" value="3"/>
-            <parameter name="maximum-duration" value="50"/>
+            <parameter name="maximum-duration" value="300"/>
         </bootstrap>
     </extensions>
     <testsuites>

diff --git a/test/EndToEnd/Version10/CustomConfiguration/test.phpt b/test/EndToEnd/Version10/CustomConfiguration/test.phpt
@@ -1,5 +1,5 @@
 --TEST--
-Configuring "maximum-count" parameter to 3 and "maximum-duration" parameter to 50 milliseconds
+Configuring "maximum-count" parameter to 3 and "maximum-duration" parameter to 300 milliseconds
 --FILE--
 <?php
 
@@ -21,16 +21,16 @@ Runtime: %s
 Configuration: %Stest/EndToEnd/Version10/CustomConfiguration/phpunit.xml
 Random %seed:   %s
 
-.............                                                     13 / 13 (100%)
+.....                                                               5 / 5 (100%)
 
-Detected 7 tests that took longer than expected.
+Detected 5 tests that took longer than expected.
 
-1. 0.2%s (0.200) Ergebnis\PHPUnit\SlowTestDetector\Test\EndToEnd\Version10\CustomConfiguration\SleeperTest::testSleeperSleepsLongerThanMaximumDurationFromSlowThresholdAnnotation
-2. 0.2%s (0.180) Ergebnis\PHPUnit\SlowTestDetector\Test\EndToEnd\Version10\CustomConfiguration\SleeperTest::testSleeperSleepsLongerThanMaximumDurationFromMaximumDurationAnnotationWhenSlowThresholdAnnotationIsPresentBeforeMaximumDuration
-3. 0.1%s (0.160) Ergebnis\PHPUnit\SlowTestDetector\Test\EndToEnd\Version10\CustomConfiguration\SleeperTest::testSleeperSleepsLongerThanMaximumDurationFromMaximumDurationAnnotationWhenSlowThresholdAnnotationIsPresentAfterMaximumDuration
+1. 0.5%s (0.300) Ergebnis\PHPUnit\SlowTestDetector\Test\EndToEnd\Version10\CustomConfiguration\SleeperTest::testSleeperSleepsLongerThanMaximumDurationFromXmlConfigurationWithDataProvider#4
+2. 0.4%s (0.300) Ergebnis\PHPUnit\SlowTestDetector\Test\EndToEnd\Version10\CustomConfiguration\SleeperTest::testSleeperSleepsLongerThanMaximumDurationFromXmlConfigurationWithDataProvider#3
+3. 0.4%s (0.300) Ergebnis\PHPUnit\SlowTestDetector\Test\EndToEnd\Version10\CustomConfiguration\SleeperTest::testSleeperSleepsLongerThanMaximumDurationFromXmlConfigurationWithDataProvider#2
 
-There are 4 additional slow tests that are not listed here.
+There are 2 additional slow tests that are not listed here.
 
 Time: %s, Memory: %s
 
-OK (13 tests, 13 assertions)
+OK (5 tests, 5 assertions)