-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic version detection #1098
base: main
Are you sure you want to change the base?
Automatic version detection #1098
Conversation
I've been thinking, this feature I'm proposing could also be implemented as a separate repo/package. If that approach is preferred, I would gladly consent to having it under the same vendor. |
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1098 +/- ##
=============================================
- Coverage 100.00% 99.68% -0.32%
- Complexity 70 84 +14
=============================================
Files 22 23 +1
Lines 11310 11352 +42
=============================================
+ Hits 11310 11316 +6
- Misses 0 36 +36 ☔ View full report in Codecov by Sentry. |
This pull request adds a new ruleset,
PhpAuto
, that picks the right ruleset based on the minimum required PHP version defined incomposer.json
of the current working directory.New dependencies added:
ext-json
(backword compatible, since it was already required by php-cs-fixer)composer/semver
(supported since PHP 5.3, so it should also be fine)Additional Changes:
Design Notes:
PHP version -> ruleset class
(e.g.[53 => Php53::class]
) map but then I thought it would be less work to just add an interface and build the class name dynamically