-
Couldn't load subscription status.
- Fork 10
Changes to support MSSQL #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ifMatt
wants to merge
6
commits into
erezsh:master
Choose a base branch
from
ifMatt:Add-MsSQL
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
965fd55
Initial Changes to support MSSQL
ifMatt 1b2d04b
Formatting changes to better conform to origin
ifMatt 3b7ea6f
Fixes based on pull request feedback.
ifMatt f726838
2nd wave of PR feedback. Also fix for foreign key column type.
ifMatt f429f22
Added in MSSQL support for three part ids. Updated test to cover new …
ifMatt 632924c
Changes to test MSSQL Connection details
ifMatt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| [tool.poetry] | ||
| name = "sqeleton" | ||
| version = "0.1.7" | ||
| version = "0.1.8" | ||
| description = "Python library for querying SQL databases" | ||
| authors = ["Erez Shinan <[email protected]>"] | ||
| license = "MIT" | ||
|
|
@@ -23,7 +23,7 @@ packages = [{ include = "sqeleton" }] | |
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.8" | ||
| runtype = ">=0.5.0" | ||
| runtype = "0.5.0" | ||
| dsnparse = "*" | ||
| click = ">=8.1" | ||
| rich = "*" | ||
|
|
@@ -41,6 +41,7 @@ textual = {version=">=0.9.1", optional=true} | |
| textual-select = {version="*", optional=true} | ||
| pygments = {version=">=2.13.0", optional=true} | ||
| prompt-toolkit = {version=">=3.0.36", optional=true} | ||
| pymssql = {version=">=2.3.2", optional=true} | ||
|
|
||
| [tool.poetry.dev-dependencies] | ||
| parameterized = "*" | ||
|
|
@@ -56,6 +57,7 @@ trino = ">=0.314.0" | |
| presto-python-client = "*" | ||
| clickhouse-driver = "*" | ||
| vertica-python = "*" | ||
| pymssql = "*" | ||
|
|
||
| [tool.poetry.extras] | ||
| mysql = ["mysql-connector-python"] | ||
|
|
@@ -69,6 +71,7 @@ clickhouse = ["clickhouse-driver"] | |
| vertica = ["vertica-python"] | ||
| duckdb = ["duckdb"] | ||
| tui = ["textual", "textual-select", "pygments", "prompt-toolkit"] | ||
| mssql = ["pymssql"] | ||
|
|
||
| [build-system] | ||
| requires = ["poetry-core>=1.0.0"] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change the version. I will do it later when I make a release.
(maybe you changed it for testing and forgot to remove?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry I was testing the difference between the versions. I have now reverted this.