Add global option to disable running clang-tidy on headers #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. FMI, what's the difference between this approach and using |
johnor
force-pushed
the
run-on-headers
branch
from
8d1576e to
83a1214
Compare
|
@erenon Hi, sorry for the late reply. I updated the commit message with some more information. I think it should answer your questions. Let me know otherwise! |
* Commit f43f9d6 added support to run clang-tidy on headers. After that commit, all headers will be checked by clang-tidy. * Commit f43f9d6 added a tag to make it possible to not run clang-tidy on specific libraries. * For projects that only want to run clang-tidy on source files, the only way to disable running clang-tidy on headers is to add the above mentioned tag to all libraries. For large projects this requires changing all BUILD files. This commit adds a global option instead to always disable running clang-tidy on headers.
johnor
force-pushed
the
run-on-headers
branch
from
83a1214 to
e5208c9
Compare
|
Fixed usage with bzlmod also, I had missed that first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.