Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funimation recognition not working #1003

Closed
wongjn opened this issue May 11, 2021 · 1 comment
Closed

Funimation recognition not working #1003

wongjn opened this issue May 11, 2021 · 1 comment
Milestone

Comments

@wongjn
Copy link

wongjn commented May 11, 2021

Taiga is no longer recognizing Funimation episodes, I believe it may be because the URL structure for shows have changed slightly from this regex:

std::regex("funimation\\.com/shows/[^/]+/[^/]+/"),

This matches for funimation.com/shows/show-name/episode-name but now stream/episode pages now have a language code prefix funimation.com/en/shows/show-name/episode-name.

Or perhaps the tab title no longer matches the regex:

std::regex("(?:Watch )?(.+) Anime.* (?:on|-) Funimation"),

Episode pages now seem to delineate with a pipe (|) instead of a dash (-) before "Funimation" now, e.g.

Watch SHOW NAME Season 1 Episode 5 Sub & Dub | Anime Simulcast | Funimation

@Roxburn
Copy link

Roxburn commented Jun 11, 2021

PR #1011 fixes this.

If you desperately want this feature I released the build here https://github.com/Roxburn/taiga/releases/tag/v1.4.0-beta.3

@erengy erengy added this to the v1.4 milestone Jul 3, 2021
erengy added a commit that referenced this issue Oct 22, 2022
Since they removed the relevant information from the page title, it's no longer possible to detect the currently playing anime.

See #994, #1003 and #1011 for details.
@erengy erengy closed this as completed Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants