Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix e2e artifacts #1054

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Jul 17, 2024

What this PR does / why we need it:

  • upload-artifacts requires unique names now
  • drop eol k8s 1.26 and add 1.30
  • bump vuln x/net dep

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 12.61% <ø> (-2.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@sozercan sozercan force-pushed the ci-fix-e2e-artifacts branch 2 times, most recently from 90c13e7 to ea6a041 Compare July 17, 2024 05:13
Signed-off-by: Sertac Ozercan <[email protected]>
Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnamehrotra ashnamehrotra merged commit e095219 into eraser-dev:main Jul 17, 2024
92 of 93 checks passed
@sozercan sozercan deleted the ci-fix-e2e-artifacts branch July 18, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants