Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use gradle-build-action #11

Merged
merged 1 commit into from
Nov 14, 2023
Merged

feat: use gradle-build-action #11

merged 1 commit into from
Nov 14, 2023

Conversation

meriouma
Copy link
Contributor

La passe-passe des gradle-properties c'est pour pas faire de breaking change dans les utilisations.

@meriouma meriouma requested a review from a team November 13, 2023 18:53
Copy link

@kbeaulieu kbeaulieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Par curiosité, pourquoi on change pour gradle-build-action?

@@ -6,14 +6,6 @@ description: |
This actions will also annotate the PR or commit with the failed tests.

inputs:
execution-only-caches:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enlever un input, ça ne cause pas d'erreur (donc un breaking change)?

Copy link
Contributor Author

@meriouma meriouma Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vais faire une majeure et gérer ça dans tous les workflows qui utilisent l'action. equisoft-actions/kotlin-workflows#25

@meriouma
Copy link
Contributor Author

Par curiosité, pourquoi on change pour gradle-build-action?

L'action est maintenue par Gradle et la gestion de la cache est supposée être meilleure. J'ai fait quelques tests pas nécessairement exhaustifs, mais ça semble enlever quand même plusieurs minutes sur nos builds.

@meriouma meriouma merged commit 2275ce0 into main Nov 14, 2023
1 check passed
@meriouma meriouma deleted the dev/QCTECH-422 branch November 14, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants