Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Well with more properties #791

Merged

Conversation

HakonHesselberg
Copy link
Collaborator

Fixes

This pull request is a prerequisite for #687

Description

Adds backend support for more properties for Wells

Type of change

  • Enhancement of existing functionality

Impacted Areas in Application

List general components of the application that this PR will affect:

  • Well backend

Checklist:

Please tick all the boxes or remove the ones that aren't needed and explain why

Communication

  • PR is related to an issue

Code quality

  • Code follows the style guidelines
  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • Existing tests pass
  • New code is covered by passing tests

@steinsiv
Copy link
Collaborator

The code looks good but I noticed that WellDatum and Location is not being populated correctly.

Example Well: /api/wells/MzBfOS1wLTNodDI=

From Witsml we get (excerpt):

    <wellDatum uid="DF">
      <name>Derrick Floor</name>
      <code>DF</code>
      <elevation uom="m" datum="SL">29</elevation>
    </wellDatum>
    <wellDatum uid="SL">
      <name>Sea Level</name>
      <code>SL</code>
    </wellDatum>

    <groundElevation uom="m">0</groundElevation>
    <waterDepth uom="m">104</waterDepth>
    
    <wellLocation uid="0">
      <latitude uom="dega">60.46</latitude>
      <longitude uom="dega">2.7</longitude>
    </wellLocation>
    <wellLocation uid="1">
      <easting uom="m">48.58</easting>
      <northing uom="m">67.27</northing>
    </wellLocation>
    <wellLocation uid="2">
      <localX uom="m">48.58</localX>
      <localY uom="m">67.27</localY>
    </wellLocation>

but returned from the API we only get this:

  "wellDatum": {
    "name": "Derrick Floor",
    "code": "DF",
    "elevation": "29"
  },
  "waterDepth": "104",
  "wellLocation": {
    "latitude": {
      "value": "60.46",
      "uom": "dega"
    },
    "longitude": {
      "value": "2.7",
      "uom": "dega"
    }
  }

This seems to be an error that should be fixed. If this is not related to this PR we need to file an issue to be fixed later. Let me know what you think.

@HakonHesselberg HakonHesselberg merged commit 119b288 into equinor:main Oct 31, 2021
@HakonHesselberg HakonHesselberg deleted the MoreWellPropertiesBackend branch October 31, 2021 13:41
@marmid74 marmid74 added the Enhancement Improvement of existing functionality label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants