Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2534 UID Mapping #2567

Merged
merged 15 commits into from
Nov 28, 2024
Merged

#2534 UID Mapping #2567

merged 15 commits into from
Nov 28, 2024

Conversation

vaclavbasniar
Copy link
Contributor

Fixes

This pull request fixes issue #2534

Description

  • added modal
  • added storage
  • updated copy and show on server functionality
  • removed connected server from list of servers in context menus
  • unit tests

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Desktop
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@vaclavbasniar vaclavbasniar force-pushed the features/2534_wellbore_uid_mapping branch from 9967148 to 2b8f9ad Compare October 21, 2024 08:14
eliasbruvik
eliasbruvik requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking a while. Started on a review, but not finished yet. Anyways, added some comments on things that can be improved, and some questions to help me understand the logic.

Src/WitsmlExplorer.Api/Models/UidMapping.cs Show resolved Hide resolved
Src/WitsmlExplorer.Api/Services/UidMappingService.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Services/UidMappingService.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/services/uidMappingService.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/services/uidMappingService.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Services/UidMappingService.cs Show resolved Hide resolved
Src/WitsmlExplorer.Api/Services/UidMappingService.cs Outdated Show resolved Hide resolved
@vaclavbasniar vaclavbasniar force-pushed the features/2534_wellbore_uid_mapping branch from 9f9a206 to 96fd79d Compare October 24, 2024 09:04
@vaclavbasniar
equinor#2534 PR changes
10a82b4 
- refactoring
- removed unused usings
- added missing objects mappings for show on server
- added missing validation
- changed complex key to serialized JSON (LiteDB doesn't support complex objects as key)
- updated tests
@vaclavbasniar
Merge branch 'main' into features/2534_wellbore_uid_mapping
3ae9c96
@vaclavbasniar
merged main
8096efc
@vaclavbasniar
equinor#2534 PR changes
fdb6dee 
- refactoring
- removed unused usings
- added missing objects mappings for show on server
- added missing validation
- changed complex key to serialized JSON (LiteDB doesn't support complex objects as key)
- updated tests
@vaclavbasniar
Merge branch 'features/2534_wellbore_uid_mapping' of https://github.c…
5fb7d74 
…om/vaclavbasniar/witsml-explorer into features/2534_wellbore_uid_mapping
@vaclavbasniar
Merge branch 'main' into features/2534_wellbore_uid_mapping
c9f5f9a 
# Conflicts:
#	Src/WitsmlExplorer.Frontend/components/ContextMenus/FluidContextMenu.tsx
#	Src/WitsmlExplorer.Frontend/components/ContextMenus/LogCurveInfoContextMenu.tsx
#	Src/WitsmlExplorer.Frontend/components/ContextMenus/LogsContextMenu.tsx
#	Src/WitsmlExplorer.Frontend/components/ContextMenus/ObjectMenuItems.tsx
#	Src/WitsmlExplorer.Frontend/components/ContextMenus/ObjectsSidebarContextMenu.tsx
#	Src/WitsmlExplorer.Frontend/components/ContextMenus/TrajectoryStationContextMenu.tsx
#	Src/WitsmlExplorer.Frontend/components/ContextMenus/TubularComponentContextMenu.tsx
#	Src/WitsmlExplorer.Frontend/components/ContextMenus/WbGeometrySectionContextMenu.tsx
#	Src/WitsmlExplorer.Frontend/components/ContextMenus/WellContextMenu.tsx
#	Src/WitsmlExplorer.Frontend/components/ContextMenus/WellboreContextMenu.tsx
@vaclavbasniar
fix after merge
2d40335
@vaclavbasniar
equinor#2534 UID Mapping
59b2d02 
* bug fixes
* automatic removal of UID mapping on well/wellbore delete
* automatic cleanup of UID mappings pointing to deleted well/wellbores on copy to
* unit tests update
@vaclavbasniar
equinor#2534 added missing readonly modifiers
4f85504
@vaclavbasniar
equinor#2534 removed unused usings
ab61635
@vaclavbasniar
Merge branch 'main' into features/2534_wellbore_uid_mapping
671d7d0
@vaclavbasniar
equinor#2534
fb47dca 
- optimization
- virtualization
- refactoring
- debounce
@vaclavbasniar
equinor#2534
f0043ff 
- removed virtualizer
- added search result limit
eliasbruvik
eliasbruvik previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@vaclavbasniar
equinor#2534
029c95f 
- fixed well node toggling
@vaclavbasniar vaclavbasniar merged commit d51c31f into equinor:main Nov 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasbruvik eliasbruvik eliasbruvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaclavbasniar @eliasbruvik