Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WE-822 implement modify formation marker #1835

Merged
merged 2 commits into from
Apr 24, 2023
Merged

WE-822 implement modify formation marker #1835

merged 2 commits into from
Apr 24, 2023

Conversation

janburak
Copy link
Contributor

@janburak janburak commented Apr 20, 2023 •
edited
Loading

Fixes

This pull request fixes WE-822

Description

  • Implement formation marker properties modal and modify worker
  • Sort modify jobs in API JobType.cs
  • Rename Struct to StratigraphicStruct in frontend
  • Move out VerifyMeasure to ModifyUtils.cs

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Fronted
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

HakonHesselberg
HakonHesselberg previously approved these changes Apr 22, 2023
View reviewed changes
Copy link
Collaborator

@HakonHesselberg HakonHesselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, but overall great job 🚀

Src/WitsmlExplorer.Api/Workers/Modify/ModifyFormationMarkerWorker.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Workers/Modify/ModifyUtils.cs Outdated Show resolved Hide resolved
HakonHesselberg
HakonHesselberg approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@HakonHesselberg HakonHesselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍸

@janburak janburak merged commit 5d3b2ac into equinor:main Apr 24, 2023
@janburak janburak deleted the WE-822 branch April 24, 2023 07:31
@janburak janburak mentioned this pull request May 5, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HakonHesselberg HakonHesselberg HakonHesselberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janburak @HakonHesselberg