WE-810 FormationMarker view #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HakonHesselberg
previously approved these changes
Apr 11, 2023
|
|
||
| namespace WitsmlExplorer.Api.Models | ||
| { | ||
| public class Struct |
There was a problem hiding this comment.
Struct seems like a name which is too generic. Would StratigraphyStruct be a better choice?
There was a problem hiding this comment.
Good suggestion, implemented.
| }); | ||
| }; | ||
|
|
||
| const columns: ContentTableColumn[] = [ |
There was a problem hiding this comment.
Would it be more efficient to use the useMemo hook here?
const columns: ContentTableColumn[] = useMemo(
() => [
{property: "name", label: "name", type: ContentType.String},
{property: "itemState", label: "itemState", type: ContentType.String},
{property: "mdPrognosed", label: "mdPrognosed", type: ContentType.String},
{property: "tvdPrognosed", label: "tvdPrognosed", type: ContentType.String},
{property: "mdTopSample", label: "mdTopSample", type: ContentType.String},
{property: "tvdTopSample", label: "tvdTopSample", type: ContentType.String},
{property: "thicknessBed", label: "thicknessBed", type: ContentType.String},
{property: "thicknessApparent", label: "thicknessApparent", type: ContentType.String},
{property: "thicknessPerpen", label: "thicknessPerpen", type: ContentType.String},
{property: "mdLogSample", label: "mdLogSample", type: ContentType.String},
{property: "tvdLogSample", label: "tvdLogSample", type: ContentType.String},
{property: "dip", label: "dip", type: ContentType.String},
{property: "dipDirection", label: "dipDirection", type: ContentType.String},
{property: "lithostratigraphic", label: "lithostratigraphic", type: ContentType.String},
{property: "chronostratigraphic", label: "chronostratigraphic", type: ContentType.String},
{property: "description", label: "description", type: ContentType.String}
],
[]
);
There was a problem hiding this comment.
Based on this article, possibly not. Moved columns out of the functional component instead, given that the dependency list would be empty.
HakonHesselberg
approved these changes
Apr 12, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This pull request fixes WE-810
Description
Implement formationMarker API routes and view.
Type of change
Impacted Areas in Application
Checklist:
Communication
Code quality
Test coverage
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...