Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tubular object View/Read #1211

Merged
merged 2 commits into from
May 23, 2022
Merged

Tubular object View/Read #1211

merged 2 commits into from
May 23, 2022

Conversation

janburak
Copy link
Contributor

@janburak janburak commented May 20, 2022 •
edited
Loading

Fixes

This pull request fixes partially #148 and #149

Description

Added functionality for viewing tubulars and an endpoint for retrieving them from a Witsml server.

Type of change

  • New feature (non-breaking change which adds functionality)

Impacted Areas in Application

Frontend, Api

Checklist:

Communication

  • PR is related to an issue
  • I have made corresponding changes to the documentation

Code quality

  • Code follows the style guidelines
  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • Existing tests pass
  • New code is covered by passing tests

@janburak janburak requested a review from steinsiv May 20, 2022 10:55
steinsiv
steinsiv approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@steinsiv steinsiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, this is a great start getting Tubular to the frontend! 👍

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@janburak janburak merged commit 5fd77b0 into equinor:main May 23, 2022
@steinsiv steinsiv mentioned this pull request Jul 5, 2022
Closed
3 tasks
@janburak janburak deleted the tubular branch August 16, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steinsiv steinsiv steinsiv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janburak @steinsiv