Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NGRM] - In WLV, need to reset twice to go back to initial prop #2151

Open
mirisb opened this issue Jul 11, 2024 · 2 comments
Open

[NGRM] - In WLV, need to reset twice to go back to initial prop #2151

mirisb opened this issue Jul 11, 2024 · 2 comments
Labels
AspenTech Task owned by AspenTech bug Something isn't working well-log-viewer

Comments

@mirisb
Copy link
Collaborator

mirisb commented Jul 11, 2024

In webviz storybook example : https://equinor.github.io/webviz-subsurface-components/storybook-static/?path=/story/welllogviewer-demo-synclogviewer--custom-layout&args=domain[0]:1000;domain[1]:3000
If I have a domain set up then I need to press twice the reset button to get to the initial display.
Denis-Shamakin pushed a commit to Denis-Shamakin/webviz-subsurface-components that referenced this issue Jul 26, 2024
fix: need to reset twice to go back (equinor#2151)
eb15e49
mirisb pushed a commit that referenced this issue Jul 29, 2024
@Denis-Shamakin @w1nklr
fix: need to reset twice to go back (#2151) (#2173)
7308582 
When the reset button is pressed, the default zoom is set. This causes
the scrolling to change and triggers the onScroll event, which sets the
overall zoom. This problem was solved by setting the "isDefZoom" flag,
which is set to "true" when setting the default scale and does not allow
the onScroll event to change the zoom

Co-authored-by: DShamakin <[email protected]>
Co-authored-by: t0oF <[email protected]>
hkfb pushed a commit that referenced this issue Jul 29, 2024
@semantic-release-bot
chore(release): [email protected] [skip ci]
5ebade9 
## [1.12.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.12.1) (2024-07-29)

### Bug Fixes

* need to reset twice to go back ([#2151](#2151)) ([#2173](#2173)) ([7308582](7308582))
@Vladimir-Kokin Vladimir-Kokin added bug Something isn't working AspenTech Task owned by AspenTech well-log-viewer labels Aug 1, 2024
@mirisb
Copy link
Collaborator Author

mirisb commented Aug 29, 2024

Bug is still re-creatable in Viz storybook when a domain is applied.

@Vladimir-Kokin
Copy link
Collaborator

Vladimir-Kokin commented Sep 10, 2024 •
edited
Loading

@mirisb Yes, when we use wellpickFlatting such error could be obtained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AspenTech Task owned by AspenTech bug Something isn't working well-log-viewer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirisb @Vladimir-Kokin