Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRTVOL2CSV Fix bug in non-contiguous active FIPNUM #770

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Feb 7, 2025

Fluid-in-place report in Eclipse will skip if there is no active cells within certain FIPNUM. This causes issue in PRTVOL2CSV since res2df will return less rows (FIPNUM) in the data frame.

volumes = (
pd.concat([simvolumes_df, resvolumes_df[: len(simvolumes_df)]], axis=1)
.apply(pd.to_numeric)
.fillna(value=0.0)
)

When this inactive FIPNUM is not the last FIPNUM, reservoir volume report will be truncated, causing the last X FIPNUM reservoir volumes set to zero (where X is the number of inactive FIPNUM)

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (e2f1947) to head (93fe56e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #770   +/-   ##
=======================================
  Coverage   85.15%   85.16%           
=======================================
  Files          52       52           
  Lines        7418     7421    +3     
=======================================
+ Hits         6317     6320    +3     
  Misses       1101     1101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alifbe alifbe marked this pull request as ready for review February 7, 2025 15:33
@alifbe alifbe requested review from a team and lilbe66 February 7, 2025 15:33
@alifbe alifbe merged commit 674e92f into equinor:main Feb 10, 2025
6 checks passed
@alifbe alifbe deleted the prtvol2csv-fix branch February 10, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants