Skip to content

Commit

Permalink
feat: cleanup workflow, always build 'nightly' containers
Browse files Browse the repository at this point in the history
  • Loading branch information
Richard87 committed Oct 14, 2024
1 parent b2e5613 commit 6529311
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 34 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/build-dev-container.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Build Dev Images

on:
push:
branches:
- main
pull_request: {}
workflow_dispatch:

Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/release-please.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ jobs:
- uses: actions/checkout@v4
- uses: googleapis/release-please-action@v4
id: release
- run: echo "${{steps.release.outputs.version}}"
- run: echo "${{steps.release.outputs.release_created}}"
- run: echo "${{steps.release.outputs.tag_name}}"

release-container:
runs-on: ubuntu-latest
Expand All @@ -34,9 +31,8 @@ jobs:
IMAGE_NAME: ${{ github.repository }}
TAG: ${{ needs.release-please.outputs.version }}
steps:
- run: echo "${{needs.release-please.outputs.version}}"
- run: echo "${{needs.release-please.outputs.release_created}}"
- uses: actions/checkout@v4

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

Expand Down Expand Up @@ -64,10 +60,12 @@ jobs:
if: ${{needs.release-please.outputs.release_created == 'true'}}
steps:
- uses: actions/checkout@v4

- name: Configure Git
run: |
git config user.name "$GITHUB_ACTOR"
git config user.email "[email protected]"
- name: Install Helm
uses: azure/setup-helm@v4
env:
Expand Down
29 changes: 0 additions & 29 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,32 +5,3 @@ Currently this exports uptime statistics using the `probe_success` metric from p
## How we work

Commits to the main branch must follow [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) and uses Release Please to create new versions.

# TODO:

- Manually patch helm chart based on please-release output
- Manually tag docker image based on please-release output

# Notes:

## Release-Please output:
```json
{
"releases_created": "true",
"release_created": "true",
"id": "179766252",
"name": "v1.3.1",
"tag_name": "v1.3.1",
"sha": "1785100949bdc314681a91e136a42248406d309f",
"body": "...",
"html_url": "https://github.com/equinor/radix-prometheus-proxy/releases/tag/v1.3.1",
"draft": "false",
"upload_url": "https://uploads.github.com/repos/equinor/radix-prometheus-proxy/releases/179766252/assets{?name,label}",
"path": ".",
"version": "1.3.1",
"major": "1",
"minor": "3",
"patch": "1",
"paths_released": "[\".\"]"
}
```

0 comments on commit 6529311

Please sign in to comment.