Fix issue with pandas 2.0 #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@berland can you help me review this PR? The test is failing due to pandas update from 1.5.3 to 2.0. |
|
Looks fine, this is perhaps pandas-dev/pandas#39022 ? Based on the number of test failures prior to this PR, it looks to be well tested :) |
berland
approved these changes
Apr 4, 2023
|
@berland Yes, I think pyscal has a very good coverage of test suite which make it much easier to flag issue. Thank for the review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest pandas (v2.0) will not update the value of the slice when using iloc which trigger error in many places of the test.
It works fine with loc.