Fix warnings #548
Merged
Fix warnings #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmfstatoil
commented
Oct 10, 2022
| * (liquidPhase.getPhase().getComponents()[i].getVolumeCorrection() | ||
| + liquidPhase.getPhase().getComponents()[i].getVolumeCorrectionT() | ||
| * (liquidPhase.getPhase().getTemperature() - 288.15)); | ||
| /* |
There was a problem hiding this comment.
Unused variable
asmfstatoil
commented
Oct 10, 2022
| int streamToCalculate = 0; | ||
|
|
||
| // double cP0 = inStream[0].getThermoSystem().getCp(); |
There was a problem hiding this comment.
unused variables
asmfstatoil
commented
Oct 10, 2022
| @@ -45,6 +45,7 @@ public ComponentHydrateGF(String component_name, double moles, double molesInPha | |||
| dataSet.getString("ID"); | |||
| } catch (Exception ex) { | |||
| logger.info("no parameters in tempcomp -- trying comp.. " + component_name); | |||
| dataSet.close(); | |||
There was a problem hiding this comment.
must close dataSet before overwriting it.
asmfstatoil
commented
Oct 10, 2022
| processOps.add(inletStream); | ||
| processOps.add(sep); | ||
| // StreamInterface gasFromSep = new Stream("liquid from separator", sep.getLiquidOutStream()); |
There was a problem hiding this comment.
unused streams
EvenSol
added a commit
that referenced
this pull request
Apr 19, 2023
* fix bug compressor (#547) * fix bug compressor * remove unused variable * Fix warnings (#548) * chore: fixed some warnings * fix compressor test (#550) * Update README.md * Update README.md * Update pom.xml (#552) * Update pom.xml * Update pom.xml * use central maven repo (#549) * Update pom.xml * Update pom.xml * Update pom.xml * Update pom.xml * Revert "use central maven repo (#549)" This reverts commit 3cd9ee7. * Create buildjars * Rename buildjars to buildjars.yaml * Rename buildjars.yaml to buildjars.yml * Create buildjarsJ8J11.yml * Update buildjarsJ8J11.yml * Delete buildjars.yml * Delete buildjarsJ8J11.yml * Add java8pom (#554) * add Java8 pom * update * Update pomJava8.xml * 556 set flow rate using unit ideal liquid sm3 as volume unit (#557) * added liquid density method * finished implementation * Formatting (#558) * refactor: formatting * AddedSevereSlug (#560) * updated two phase flow sim * add Beggs and Brills * BeggsAndBrillsMethod * BeggsAndBrills * AddedSevereSlug * AddedSevereSlug * changed constructor * Update Co-authored-by: Even Solbraa <[email protected]> * chore: added javadoc (#562) * Change method to public (#564) * 566 set flow rate from a splitter (#567) * added flow method to splitter * updated valve calc * Create build8.yml * Update build8.yml * Update pomJava8.xml * Test fixes (#569) * feat: added delta to numeric comparison assertion * deprecated function call * system.out.println -> logger.info * Create release_with_jars.yml (#570) * Create release_with_jars.yml * Update release_with_jars.yml * Update release_with_jars.yml * Update release_with_jars.yml * Update release_with_jars.yml * Update workflow.yml * Update release.yml * Update build8.yml * Update build.yml * Update pr_test.yml * Update release_with_jars.yml * Update release_with_jars.yml * Update release_with_jars.yml * Update build8.yml * Update build.yml * Update pr_test.yml * Update release_with_jars.yml * Update release_with_jars.yml * Update release_with_jars.yml * Update release_with_jars.yml * Update release_with_jars.yml * Set splitter flow (#568) * added flow method to splitter * updated valve calc * fixed bug * add virtual stream (#572) * Update log4j2.properties * fix minor bug split stream (#574) * Fixed release_with_jars.yml (#575) * Update release_with_jars.yml * fix workflow (#576) * Update release_with_jars.yml * Update release_with_jars.yml (#577) * update version (#578) * Bug fix split (#579) * fix minor bug split stream * fix bug * bug fix * Update release.yml * Update release.yml * Update workflow.yml * Fixbugs splitter (#580) * fix minor bug split stream * fix bug * bug fix * fix splitter bugs * Fix splitter 2 (#581) * fix minor bug split stream * fix bug * bug fix * fix splitter bugs * update recycle accuracy * Update release_with_jars.yml * chore: update workflow to publishj jars to neqsimpython (#582) * Update release_with_jars.yml * Update README.md * chore: joined build tests workflows in verify_build (#583) * chore: clean up workflows * Update verify_build.yml * chore: clean up workflows (#585) * refact: fixes to remove problems when running javadoc:fix (#586) * refact: fixes to remove problems when running javadoc:fix * fix * 587 add compressibility functions x and y (#588) * added compressibility functions * updated tests * update ejml to version 0.41.1 (#591) * Replace static variables umrpr (#592) * addedTest on async UMR * Replace static VCommon and FCcommon in UMRPR * Delete test (not async) * Update PhaseGEUnifacUMRPRU.java * Updage getVCommontemp and getFCommontemp ComponentGEUnifacUMRPRU.java changed Co-authored-by: Even Solbraa <[email protected]> * Update verify_build.yml * update to version 2.4.2 (#593) * update to version 2.4.2 * Update pomJava8.xml * fix: upgrade org.jfree:jfreechart from 1.5.3 to 1.5.4 (#596) Snyk has created this PR to upgrade org.jfree:jfreechart from 1.5.3 to 1.5.4. See this package in Maven Repository: https://mvnrepository.com/artifact/org.jfree/jfreechart/ See this project in Snyk: https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]> * update ejml to version 0.42 (#597) * Update pomJava8.xml * Update pomJava8.xml * Add files via upload * fix: upgrade org.apache.logging.log4j:log4j-core from 2.19.0 to 2.20.0 (#600) Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-core from 2.19.0 to 2.20.0. See this package in Maven Repository: https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core/ See this project in Snyk: https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr * fix: upgrade org.apache.logging.log4j:log4j-api from 2.19.0 to 2.20.0 (#601) Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.19.0 to 2.20.0. See this package in Maven Repository: https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-api/ See this project in Snyk: https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr * Release 2.4.3 - update pom * Update pom.xml * Update pomJava8.xml * Update release_with_jars.yml (#605) * Update release_with_jars.yml * Update release_with_jars.yml * docfix and style (#607) * chore: fix name of test functions (#608) * docfix and style (#609) * docfix and style, formatting some reordering of functions to remove warnings * 603 use parameters from csv files create database on start (#604) * added tables * chaged format * some test neqsimdb * added sql * update database * update tabel * modified tables * update from master (#606) * Update release_with_jars.yml (#605) * Update release_with_jars.yml * Update release_with_jars.yml --------- Co-authored-by: Åsmund Våge Fannemel <[email protected]> * updates * updated tests * fixed tests * added more tables * add more tables * update * deleted * update * fixed tables * updates * updates * updates removed derby * fixed reaction data table * update java 8 pom --------- Co-authored-by: Åsmund Våge Fannemel <[email protected]> * 610 add ammonia nh3 to the parameters database (#611) * add component ammonia * modified test * make version 2.4.4 (#612) * make version 2.4.4 * Update pomJava8.xml * fix: change logger.info to exception (#616) * feat: addedModuleSolutions (#615) * feat: addedModuleSolutions * fix: javadoc * improved setPressure method (#619) * updated method * improved method * added test for setPressure * vuscosity update (#620) * added possibility to update table (#613) * add test (#621) * Add dbtest2 (#622) * add test * update * Update NeqSimDataBaseTest.java * Add dbtest3 (#623) * add test * update * add test * feat:nmVOCFlowRateAdded (#617) * fix: change logger.info to exception * feat: methodToCalcFlowRateOfnmVOC * fix:correct test * add analyser instrument * added test for NMVOCAnalyser * Update SystemInterface.java * Update SystemThermo.java * Delete ComponentTest.java --------- Co-authored-by: Even Solbraa <[email protected]> * Update component property doc (#614) * added possibility to update table * addd ammonia * update * Update AmmoniaTest.java * Update NewComponentTest.java * version 2.4.5 (#624) * Update pom.xml * Update pomJava8.xml * feat: updateModuleClass (#625) * version 2.4.6 (#626) * Update pom.xml * Update pomJava8.xml --------- Co-authored-by: Åsmund Våge Fannemel <[email protected]> Co-authored-by: Sviatoslav Eroshkin <[email protected]> Co-authored-by: snyk-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.