Glycolrigfix #458
Merged
Glycolrigfix #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmfstatoil
reviewed
Jul 15, 2022
| @@ -310,6 +310,16 @@ public double findOutPressure(double hinn, double hout, double polytropicEfficie | |||
| @Override | |||
| public void run() { | |||
| thermoSystem = inStream.getThermoSystem().clone(); | |||
|
|
|||
| if(Math.abs(pressure-thermoSystem.getPressure(pressureUnit))<1e-6 && !compressorChart.isUseCompressorChart()) { | |||
There was a problem hiding this comment.
the comparison with 1e-6 looks like a unit specific comparison. PressureUnit is a variable?
Code is also not properly formatted.
There was a problem hiding this comment.
Thanks - I will try to fix it. PressureUnit is a variable, because it can be specified when setting pressure out of the compressor. The reason for using 1e-6 was just to add a small number, to prevent errors when in and out pressure is the same (compressor not doing work). NeqSim gave an error when pressure in and out was the same, and this was a fix for that (and to prevent unnecessary calculations).
asmfstatoil
reviewed
Jul 15, 2022
| @@ -64,4 +64,6 @@ default public StreamInterface getOutStream() { | |||
| /** {@inheritDoc} */ | |||
| @Override | |||
| public SystemInterface getThermoSystem(); | |||
|
|
|||
| public void removeInputStream(int i); | |||
asmfstatoil
reviewed
Jul 15, 2022
| @@ -1741,12 +1741,14 @@ public ComponentInterface getComponent(String name) { | |||
| return componentArray[i]; | |||
| } | |||
| } | |||
| logger.error("could not find component... " + name + " ..returning null"); | |||
| logger.error("could not find component " + name + ", returning null"); | |||
There was a problem hiding this comment.
Redundant to log when catching and logging just below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.