controller initial work #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmfstatoil
reviewed
Apr 19, 2022
src/main/java/neqsim/processSimulation/processEquipment/ProcessEquipmentBaseClass.java
Outdated
Show resolved
Hide resolved
refact: typo
asmfstatoil
force-pushed
the
add_process_controller
branch
from
171f528 to
af3f8f5
Compare
Merged
|
if (getCalculateSteadyState()) if (getCalculateSteadyState()) is true - then the unit operation should be calculated as steady stat using normal run operation. For me it seems as the opposite is done (that transient is run if getCalculateSteadyState() is true. |
|
That is a bug/typo, i'll fix it |
|
@EvenSol ready for review, but without all the steady state calculation parts |
|
This seems fine and can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.