Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering on magazine tags on the /no/magasin page goes to Norwegian homepage instead of filtering #2687

Closed
meols opened this issue Nov 20, 2024 · 3 comments
Closed

Filtering on magazine tags on the /no/magasin page goes to Norwegian homepage instead of filtering #2687

meols opened this issue Nov 20, 2024 · 3 comments
Assignees
@VarunVAshrit
Labels
🐛 bug Something isn't working

Comments

@meols
Copy link
Collaborator

meols commented Nov 20, 2024 •
edited
Loading

When clicking on one of the tags to filter, the url change to this (without /magasin)
image.png
@meols meols added the 🐛 bug Something isn't working label Nov 20, 2024
@VarunVAshrit VarunVAshrit self-assigned this Dec 9, 2024
VarunVAshrit added a commit that referenced this issue Dec 17, 2024
@VarunVAshrit
Filtering on magazine tags on the /no/magasin page goes to Norwegian …
c7e3217 
…homepage instead of filtering #2687
@VarunVAshrit VarunVAshrit mentioned this issue Dec 17, 2024
Merged
VarunVAshrit added a commit that referenced this issue Dec 18, 2024
@VarunVAshrit
Revert "Filtering on magazine tags on the /no/magasin page goes to No…
4aa4878 
…rwegian homepage instead of filtering #2687"

This reverts commit c7e3217.
VarunVAshrit added a commit that referenced this issue Dec 18, 2024
@VarunVAshrit
Revert "Filtering on magazine tags on the /no/magasin page goes to No…
3fdb826 
…rwegian homepage instead of filtering #2687"

This reverts commit c7e3217.
@meols
Copy link
Collaborator Author

meols commented Jan 2, 2025

Thanks @VarunVAshrit, the filters are filtering and not going to the Norwegian homepage - but the thumbnails in the results list and also on the magazine landing page (both English and Norwegian) are not stacked horizontally and have different sizes when selecting different filters (due to the different number of hits maybe?)
image.png

image.png

image.png

image.png

@VarunVAshrit
Copy link
Collaborator

Hey @meols .The changes are done. Please verify.

@meols
Copy link
Collaborator Author

meols commented Jan 13, 2025

Thanks @VarunVAshrit - this looks good now 😄 Approved

VarunVAshrit added a commit that referenced this issue Jan 16, 2025
@VarunVAshrit
Filtering on magazine tags on the /no/magasin page goes to Norwegian … (
bac3b05 
#2727)

* Filtering on magazine tags on the /no/magasin page goes to Norwegian homepage instead of filtering #2687

* Removed commented code

* Revert "Removed commented code"

This reverts commit 27daac5.

* Revert "Filtering on magazine tags on the /no/magasin page goes to Norwegian homepage instead of filtering #2687"

This reverts commit c7e3217.

* 🐛Filtering on magazine tags on the /no/magasin page

* 🐛 Changed parentSlug

* Changed grid-cols-card

* Changed grid-cols-card again
@padms padms closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VarunVAshrit VarunVAshrit

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@padms @meols @VarunVAshrit