Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for TextBlock to render if it only has a CTA #1530

Closed
SvSven opened this issue Feb 20, 2023 · 4 comments
Closed

allow for TextBlock to render if it only has a CTA #1530

SvSven opened this issue Feb 20, 2023 · 4 comments
Assignees
@SvSven
Labels
🌐 Next.js (web) 🚀 ready to deploy Use this if issue is ready to be deployed

Comments

@SvSven
Copy link
Contributor

SvSven commented Feb 20, 2023

In some cases the editorial team needs to display just a link. Currently, the TextBlock component does not render if it does not have a title, ingress, and text.

We should update this to allow for only links to be rendered.
@SvSven SvSven self-assigned this Feb 20, 2023
SvSven added a commit that referenced this issue Feb 20, 2023
@SvSven
✨update TextBlock guard to allow only CTAs (#1530)
29e0d18
@SvSven
Copy link
Contributor Author

SvSven commented Feb 20, 2023

@padms @millianapia ready for testing 🎉

@millianapia
Copy link
Contributor

looks good, and it works!

@SvSven
Copy link
Contributor Author

SvSven commented Feb 20, 2023

@NickHaggerty1 @meols This should fix the issue with the text block not appearing when it only has a link.

@NickHaggerty1
Copy link
Collaborator

Nice, thanks @SvSven. Approved....

@SvSven SvSven added the 🚀 ready to deploy Use this if issue is ready to be deployed label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SvSven SvSven

Labels
🌐 Next.js (web) 🚀 ready to deploy Use this if issue is ready to be deployed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SvSven @millianapia @NickHaggerty1