-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As editors we see a need to a simple image carousel component to communicate a image story or timeline #1339
Comments
@meols fyi, and please add any acceptance criteria |
Looks good @NickHaggerty1 - nothing to add 😄 |
I have made some sketches in Figma. The page TOP BANNER has a carousel ++ artboard. Im open for input in how best to solve the scroll left and right and display how many options there are. I have some different design options. We have to consider that the same functionality needs to be applied to horizontal scroll on promotion components etc too ref #1373. I suggest we take a meeting on this before the developers start this issue, just to clarify. Let me know when that could happen |
Will be partially solved in #1373 |
For design of left and right arrows @SvSven will use the examples in TOP BANNER on figma as a basis and we will look at options to confirm the design once in Sanity. |
Some work here was done alongside #1373 - however there are some differences between the 2 components. We can (and should) use the same library for both solutions: https://swiperjs.com/swiper-api Examples of some customization/implementation can be found in the horizontal scroll component for #1373 |
@fernandolucchesi @millianapia @padms This is ready for technical review |
added a few comments, but looks very good otherwise! |
Actually forgot to make the autoplay dependent on the chosen value in Sanity - should be fixed now 😅 |
@fernandolucchesi @meols @SvSven. I say approved! |
Acceptance criteria
The text was updated successfully, but these errors were encountered: