Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As editors we see a need to a simple image carousel component to communicate a image story or timeline #1339

Closed
NickHaggerty1 opened this issue Nov 2, 2022 · 12 comments
Assignees
Labels
🚀 ready to deploy Use this if issue is ready to be deployed 📇 user story This issue represents a user story 🎨 UX

Comments

@NickHaggerty1
Copy link
Collaborator

NickHaggerty1 commented Nov 2, 2022

Acceptance criteria

  1. Editor can add images (with same upload settings as Image component - fotoware/upload etc)
  2. Size should display 2:1 same as default banner on topic page
  3. Editor can add SVGs
  4. Editor can Crop/hotspot on images
  5. Editor can add optional image text per image added in same style as image component
  6. Carousel should auto rotate, editor can set transition speed in seconds
  7. Carousel should also have options for users to click through.
  8. Carousel should indicate amount of transitions for user
  9. Optional title for component (Not per transition)
  10. Options on colour background as per other components
  11. Component should be available for use on Magazine and topic templates
@NickHaggerty1 NickHaggerty1 added the 📇 user story This issue represents a user story label Nov 2, 2022
@NickHaggerty1
Copy link
Collaborator Author

@meols fyi, and please add any acceptance criteria

@meols
Copy link
Collaborator

meols commented Nov 2, 2022

Looks good @NickHaggerty1 - nothing to add 😄

@fernandolucchesi
Copy link
Contributor

#1313

@NickHaggerty1
Copy link
Collaborator Author

NickHaggerty1 commented Nov 30, 2022

I have made some sketches in Figma. The page TOP BANNER has a carousel ++ artboard. Im open for input in how best to solve the scroll left and right and display how many options there are. I have some different design options. We have to consider that the same functionality needs to be applied to horizontal scroll on promotion components etc too ref #1373. I suggest we take a meeting on this before the developers start this issue, just to clarify. Let me know when that could happen

@SvSven
Copy link
Contributor

SvSven commented Dec 1, 2022

Will be partially solved in #1373

@NickHaggerty1
Copy link
Collaborator Author

NickHaggerty1 commented Dec 15, 2022

For design of left and right arrows @SvSven will use the examples in TOP BANNER on figma as a basis and we will look at options to confirm the design once in Sanity.
We will go for a number indicator display to tell user which slide they are on and how many..... 1 / 6 for example

@NickHaggerty1
Copy link
Collaborator Author

carosuel-image-text.png

@SvSven
Copy link
Contributor

SvSven commented Dec 20, 2022

Some work here was done alongside #1373 - however there are some differences between the 2 components. We can (and should) use the same library for both solutions: https://swiperjs.com/swiper-api

Examples of some customization/implementation can be found in the horizontal scroll component for #1373

@SvSven
Copy link
Contributor

SvSven commented Jan 26, 2023

@fernandolucchesi @millianapia @padms This is ready for technical review

@millianapia
Copy link
Contributor

added a few comments, but looks very good otherwise!

@SvSven
Copy link
Contributor

SvSven commented Jan 27, 2023

Actually forgot to make the autoplay dependent on the chosen value in Sanity - should be fixed now 😅

@NickHaggerty1
Copy link
Collaborator Author

@fernandolucchesi @meols @SvSven. I say approved!

@SvSven SvSven added the 🚀 ready to deploy Use this if issue is ready to be deployed label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to deploy Use this if issue is ready to be deployed 📇 user story This issue represents a user story 🎨 UX
Projects
None yet
Development

No branches or pull requests

5 participants