chore: Enable revive and stylecheck in golangci linters#849
Merged
Conversation
ctreatma
reviewed
Feb 3, 2025
ctreatma
force-pushed
the
linter_updates
branch
from
2f1cb48 to
9b23943
Compare
Signed-off-by: Charles Treatman <1090793+ctreatma@users.noreply.github.com>
ctreatma
approved these changes
Feb 4, 2025
ctreatma
added a commit
that referenced
this pull request
Feb 5, 2025
Since we might periodically change linter configuration, as done in #849, we should keep the existing PR validation behavior that only lints the files that were changed in a particular PR. This will allow us to continue to avoid unnecessarily large PRs to fix linting failures if and when the linter configuration changes. If we're keeping the current, limited PR validation behavior, we should use the same behavior for the `make lint` task to that developers can easily identify the minimum necessary changes locally. This updates the `make lint` task to only lint files that have been changed since `origin/main`, which should closely approximate the behavior of the PR validation workflow.
|
This PR is included in version 3.2.0 🎉 |
kpdhulipala
pushed a commit
to kpdhulipala/terraform-provider-equinix
that referenced
this pull request
Mar 24, 2025
* Enable `revive` and `stylecheck` linters --------- Signed-off-by: Charles Treatman <1090793+ctreatma@users.noreply.github.com> Co-authored-by: Charles Treatman <1090793+ctreatma@users.noreply.github.com>
kpdhulipala
pushed a commit
to kpdhulipala/terraform-provider-equinix
that referenced
this pull request
Mar 24, 2025
Since we might periodically change linter configuration, as done in equinix#849, we should keep the existing PR validation behavior that only lints the files that were changed in a particular PR. This will allow us to continue to avoid unnecessarily large PRs to fix linting failures if and when the linter configuration changes. If we're keeping the current, limited PR validation behavior, we should use the same behavior for the `make lint` task to that developers can easily identify the minimum necessary changes locally. This updates the `make lint` task to only lint files that have been changed since `origin/main`, which should closely approximate the behavior of the PR validation workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reviveandstylechecklinters