feat: upgrade openapi-generator to v7.16.0 #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
commented
Oct 21, 2025
Comment on lines
-92
to
-127
| // check if the discriminator value is 'BgpRoutingProtocolRequest' | ||
| if jsonDict["type"] == "BgpRoutingProtocolRequest" { | ||
| // try to unmarshal JSON data into BgpRoutingProtocolRequest | ||
| err = json.Unmarshal(data, &dst.BgpRoutingProtocolRequest) | ||
| if err == nil { | ||
| return nil // data stored in dst.BgpRoutingProtocolRequest, return on the first match | ||
| } else { | ||
| dst.BgpRoutingProtocolRequest = nil | ||
| return fmt.Errorf("failed to unmarshal ServiceRequestAllOfRoutingProtocol as BgpRoutingProtocolRequest: %s", err.Error()) | ||
| } | ||
| } | ||
|
|
||
| // check if the discriminator value is 'DirectRoutingProtocolRequest' | ||
| if jsonDict["type"] == "DirectRoutingProtocolRequest" { | ||
| // try to unmarshal JSON data into DirectRoutingProtocolRequest | ||
| err = json.Unmarshal(data, &dst.DirectRoutingProtocolRequest) | ||
| if err == nil { | ||
| return nil // data stored in dst.DirectRoutingProtocolRequest, return on the first match | ||
| } else { | ||
| dst.DirectRoutingProtocolRequest = nil | ||
| return fmt.Errorf("failed to unmarshal ServiceRequestAllOfRoutingProtocol as DirectRoutingProtocolRequest: %s", err.Error()) | ||
| } | ||
| } | ||
|
|
||
| // check if the discriminator value is 'StaticRoutingProtocolRequest' | ||
| if jsonDict["type"] == "StaticRoutingProtocolRequest" { | ||
| // try to unmarshal JSON data into StaticRoutingProtocolRequest | ||
| err = json.Unmarshal(data, &dst.StaticRoutingProtocolRequest) | ||
| if err == nil { | ||
| return nil // data stored in dst.StaticRoutingProtocolRequest, return on the first match | ||
| } else { | ||
| dst.StaticRoutingProtocolRequest = nil | ||
| return fmt.Errorf("failed to unmarshal ServiceRequestAllOfRoutingProtocol as StaticRoutingProtocolRequest: %s", err.Error()) | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The code removed here is effectively unreachable; it tests for type property values that do not exist in the spec. The spec-derived type checks immediately precede the removed code in this file and they check for values that are actually defined in the spec.
ctreatma
commented
Oct 21, 2025
ctreatma
commented
Oct 21, 2025
ctreatma
force-pushed
the
upgrade-openapi-generator
branch
from
9daf05a to
a61f2c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.