Closed
Conversation
Contributor
|
Interesting initiative! For me personally it is too early to give any meaningful feedback. I'd try to add some tests or even proceed in a TDD manner. When things get too tricky to test in a straightforward way, it is a sign of a necessary change (likely a new abstraction to be added). Once a working prototype (at leas basic sync is handled: new block is processed, no reorg, no "healing" etc) is ready (with meaningful test coverage), then providing feedback is going to be much easier, at least for me. |
Mirko-von-Leipzig
force-pushed
the
sync_p2p
branch
from
65c9dae to
604ad6f
Compare
Mirko-von-Leipzig
force-pushed
the
sync_p2p
branch
from
604ad6f to
d60c7e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking for feedback on this wip sync redesign. Specifically, the
async fn track()part (the rest is just me trying to think atm).I'm trying to use futures instead of message / events.